abhinav-phi commented on PR #2112:
URL: https://github.com/apache/stormcrawler/pull/2112#issuecomment-5513406838
The rat failure on 8aea8e9c was a compile error I introduced with the
removal of `ParseResult.get()`: `JsRenderingDetectorTest` holds the
`ParseResult` in a variable named `p`, so the earlier mechanical rename of
`parse.get(...)` missed its 14 call sites. Fixed in 5a44a45b by switching those
to `getOrCreate("u")`, and verified locally with a full `mvn clean verify`
across the whole reactor (all 18 modules build, checkstyle and
google-java-format clean).
The CI run for 5a44a45b is currently waiting for a maintainer to approve it
(workflow runs from first-time contributors require manual approval) — once
approved it should go green.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
