abhinav-phi commented on PR #2110: URL: https://github.com/apache/stormcrawler/pull/2110#issuecomment-5514252831
@rzo1 pushed 727ec1df addressing all nine review comments: the deprecated static getDigestSha1 methods are removed, getDigest validates its inputs, null/blank algorithm values fall back to SHA-1 like an unset one, and the constructors of all three record formats now carry javadoc. Local verify is green (30 tests, format validation, checkstyle). The CI run needs another maintainer approval after the push: https://github.com/apache/stormcrawler/actions/runs/33665614229 — could you (or @jnioche / @dpol1) trigger it? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
