The GitHub Actions job "Java CI with Maven" on 
stormcrawler.git/issue-2088-redirect-filtering has failed.
Run started by GitHub user abhinav-phi (triggered by dpol1).

Head commit for run:
5c1e6609c348355e5608d45eec30caf527d78435 / abhinav-phi <[email protected]>
Follow redirects through the same client, keep credentials scoped (#2088)

Review feedback on #2128:

- the redirect loop now runs each request through the same client the
  first request used, so a fetch configured with a dynamic proxy keeps
  using it for every hop
- an https to http downgrade is refused outright; credentials are
  stripped (authorization, cookie) whenever a hop changes origin, like
  okhttp's own follower does on a host change
- the 'more than N redirect hops' warning only fires when the chain
  actually exhausted the hop budget, not when the final response
  happened to be a normal one
- the hop limit is configurable with http.allow.redirects.max (default
  5) instead of a hard-coded constant
- the final URL is recorded under ProtocolResponse.REDIRECTED_TO_KEY
  (_redirectedTo), distinct from the _redirTo key the fetcher and
  parser bolts set on Status.REDIRECTION tuples, with a javadoc on the
  constant relating the two
- code reformatted with google-java-format 1.35.0 (the version the
  git-code-format plugin uses); the earlier local runs had silently
  skipped the format check on Windows

Report URL: https://github.com/apache/stormcrawler/actions/runs/34150507848

With regards,
GitHub Actions via GitBox

Reply via email to