abhinav-phi commented on PR #2127:
URL: https://github.com/apache/stormcrawler/pull/2127#issuecomment-5574422474
Thanks — pushed 55395054 closing everything:
- **CGNAT regex:** fixed to `6[4-9]|[7-9][0-9]|1[01][0-9]|12[0-7]` in the
archetype and both external copies; `100.65.0.1` (blocked) and `100.63.0.1`
(accepted) are in the tests, both ends of the mistake.
- **Case:** the private-range rules now carry `(?i)` — `LOCALHOST`,
`[FD00::1]`, `[FE80::1]` are pinned by `caseInsensitiveSpellingsAreRejected`.
- **Loopback via IPv6 literals:** added your suggested rule for
`::ffff:127.0.0.1` and the fully-expanded `(0*:){7}0*1` form, pinned by tests.
- **Unrelated change:** reverted
`core/src/test/resources/default-regex-filters.txt` to its upstream content.
The archetype rules ship as `default-regex-filters-archetype.txt` for the new
test instead, so `RegexFilterTest`/`URLFilterBoltTest` are untouched.
- **Yaml advice:** corrected — the comment now says exclude rules win over
include rules and the operator has to override `http.filter.ipaddress.exclude`
explicitly (e.g. `""`). Also took the opportunity to fix the shipped value to
`fc00::/7` (full ULA), consistent with what #2119 is doing to the example.
- **Resolver notes:** put into the description — hex is rejected
(`UnknownHostException`) and leading zeros are not octal (`0177.0.0.1` →
`177.0.0.1`, public), so the `\d{1,10}` rule closes the only numeric form that
works; a test documents both.
Overlapping with #2119: #2127 owns the *shipped value* of
`http.filter.ipaddress.exclude` (it flips it from commented to enabled); #2119
only updates the commented example and the keyword docs. #2119 merges first and
I'll rebase this one if the lines collide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
