The GitHub Actions job "Java CI with Maven" on 
stormcrawler.git/issue-2080-private-address-default has failed.
Run started by GitHub user abhinav-phi (triggered by rzo1).

Head commit for run:
5539505475c99842eab2212f10aa9b4a1c98e8d5 / abhinav-phi <[email protected]>
Fix the CGNAT regex, close case and IPv6-literal gaps (#2080)

Review feedback on #2127:

- the CGNAT alternation blocked 100.60-100.63 (public space) and missed
  100.65-100.69 entirely: the second octet runs 64 to 127, so the first
  branch is 6[4-9]. Tests pin 100.65.0.1 as blocked and 100.63.0.1 as
  accepted, both ends of the mistake
- RegexURLFilter compiles case-sensitively, so LOCALHOST, [FD00::1] and
  [FE80::1] slipped past the rules: the private-range rules carry (?i)
- ::ffff:127.0.0.1 and 0:0:0:0:0:0:0:1 resolve to loopback through the
  JVM resolver and matched nothing: a rule catches the IPv4-mapped and
  fully expanded loopback literals
- the yaml opt-out advice was wrong: exclude rules win over include
  rules in IPFilterRules.accept, so an operator has to override
  http.filter.ipaddress.exclude explicitly; the comment says so, and
  the shipped exclude list covers the full ULA range (fc00::/7)
- core/src/test/resources/default-regex-filters.txt is back to its
  upstream content: RegexFilterTest and URLFilterBoltTest load it, and
  overwriting it here was an unrelated change. The archetype rules
  ship as default-regex-filters-archetype.txt for the new test instead
- the description documents that the resolver rejects hex (0x7f000001)
  and does not read leading zeros as octal, so the \d{1,10} rule
  closes the only numeric form that actually works

Report URL: https://github.com/apache/stormcrawler/actions/runs/34151677904

With regards,
GitHub Actions via GitBox

Reply via email to