rzo1 commented on PR #2119: URL: https://github.com/apache/stormcrawler/pull/2119#issuecomment-5574839248
Every one of these PRs is currently red on the `rat` job, and in each case for the same reason: `maven-checkstyle-plugin` reports `CustomImportOrder` violations — unsorted imports and an extra blank line in the import group. Between them that's ~200 violations across nine PRs. The practical effect isn't really the CI minutes. It's that `build` is declared `needs: rat`, so the entire test matrix is skipped and none of these PRs has produced a single real test result yet. When I open one to review, I can't tell whether the change works — I only know the imports are in the wrong order. That turns each PR into two review passes instead of one, and with nine of them open simultaneously that's the actual bottleneck on my side. This is already documented in `README.md` under "Note for developers". Before pushing: ``` mvn git-code-format:format-code -Dgcf.globPattern="**/*" -Dskip.format.code=false ``` Or install the pre-commit hook once and stop thinking about it: ``` mvn clean install -Dskip.format.code=false ``` To reproduce exactly what CI runs: ``` mvn -B -Prat -DskipTests verify -Dskip.format.code=false ``` Could you add that formatting step to your agent's pre-push routine? Once these are green I'm happy to review the substance — several of them look like changes the project wants. For reference, #2118 formatted cleanly, passed `rat`, and is running the full matrix right now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
