abhinav-phi commented on PR #2123: URL: https://github.com/apache/stormcrawler/pull/2123#issuecomment-5574528856
Thanks — pushed c9a67d08: - **The while loop:** adopted your suggestion — a rejected row is now emitted to the status stream as `Status.ERROR` (`url, metadata, status` on `Constants.StatusStreamName`), so the status updater removes it from the store instead of it coming back with every query. `AbstractQueryingSpout.declareOutputFields` declares the status stream, and `SQLSpout` (the only subclass with its own `declareOutputFields`) declares it too; OpenSearch, Solr and URLFrontier spouts inherit the declaration. Test pins the ERROR emission. - **Locale:** `.map(s -> s.toLowerCase(Locale.ROOT))` — good catch on the Turkish-locale case. - **`buffer.next()` returning null:** guarded with a `break`. - Dropped the redundant `buffer.hasNext()` and fixed the javadoc-close formatting. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
