abhinav-phi commented on PR #2125: URL: https://github.com/apache/stormcrawler/pull/2125#issuecomment-5593080385
Thanks — pushed fcf0664b addressing all three points: **Media-type parsing:** `sniffsAsSitemap` no longer substring-matches the header. It strips parameters (everything from the first `;"), compares the bare media type, and excludes `*html+xml` (XHTML and friends) explicitly — so neither `application/xhtml+xml` nor `text/html; profile=xml` can promote a page to sitemap parsing. Allowed types for promotion are `application/xml`, `text/xml`, any other `+xml`, `text/plain` and `application/octet-stream`. **Tests:** `sniffingRequiresSitemapCompatibleContentType` now actually enables `sitemap.sniffContent` (good catch — it never did), and two new tests pin the XHTML and parameterised-HTML rejections; `xmlContentTypeWithNamespaceIsPromotedWhenSniffingEnabled` covers the positive promotion path so the guard cannot silently over-tighten either. **Description:** corrected — the PR body now says `sitemap.strict` defaults to false, matching the implementation since f880c11. Local gates: checkstyle 0 on the full reactor, format validation clean (formatted with the `-Dgcf.globPattern="**/*"` glob from the README so test files are covered), 21 sitemap tests pass. The workflow run will need a maintainer's workflow approval. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
