dpol1 commented on code in PR #2146:
URL: https://github.com/apache/stormcrawler/pull/2146#discussion_r3976679992
##########
external/sql/src/main/java/org/apache/stormcrawler/sql/IndexerBolt.java:
##########
@@ -99,6 +128,16 @@ public void execute(Tuple tuple) {
Map<String, String[]> keyVals = filterMetadata(metadata);
List<String> keys = new ArrayList<>(keyVals.keySet());
+ // drop anything that is not a plain identifier before it reaches
the statement
+ keys.removeIf(
Review Comment:
this also runs on alias and plain-mapping labels: a column like `col$1` or
one with an accented letter, which MySQL takes unquoted, stops being indexed
with just a warn. intended, or should the check only cover glob labels?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
