GGraziadei commented on code in PR #2135:
URL: https://github.com/apache/stormcrawler/pull/2135#discussion_r4014870767
##########
core/src/main/java/org/apache/stormcrawler/bolt/FetcherBolt.java:
##########
@@ -1017,17 +993,33 @@ public void run() {
collector.emit(Constants.StatusStreamName, fit.tuple,
tupleToSend);
}
+ } catch (FetchTimeoutHelpers.SaturatedException e) {
+ // the URL never reached the network: like a URL which
waited too long in
+ // the queue, it is acked without a status so that the
spout retries it
+ // later, rather than taking a strike towards
max.fetch.errors
+ eventCounter.scope("fetch.helper.rejected").incrBy(1);
+ LOG.warn(
+ "[Fetcher #{}] {}: all {} fetch helpers are busy",
+ taskId,
+ e.getMessage(),
+ fetchHelpers.maxHelpers());
+ asap = true;
Review Comment:
Good catch, thanks! I am checking something like exponential backoff with
equal jitter implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
