rzo1 opened a new pull request, #2170: URL: https://github.com/apache/stormcrawler/pull/2170
The protocols copy every response header into the response metadata, so a header named `metrics.something` lands in the namespace the bolts read their protocol timings from. `Long.parseLong` was called unguarded, so a non-numeric value threw inside the fetch block and a response that had arrived intact was recorded as `FETCH_ERROR`, with a bare `NumberFormatException` as the reason. The parsing moves into a helper shared by both bolts, which skips a value it cannot parse and logs it. This is the bolt-side half. Stopping the server from creating those keys at all is in #2091, which strips `metrics.*` in the protocols; between the two, #2099 can close. Once both are in, `ProtocolMetrics` should use `ProtocolResponse.METRICS_PREFIX` rather than its own copy of the string. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
