rzo1 commented on PR #2236: URL: https://github.com/apache/stormcrawler/pull/2236#issuecomment-6250049212
> `httpcore5`-only looks fine to me for 4.0.0. After this change no HttpComponents type is left in core's public API, so copying the few classes can come in a follow-up without another API break. @jnioche @rzo1, ok with that? I would avoid having the API dependency at all. 4.0.0 is a possiblity to break things, which is hard to argue for any subsequent dot release actually. We dropped the Apache HTTP Protocol Implementation for 4.0.0, in https://github.com/apache/stormcrawler/commit/4d49466df34dbd094d09021d1bc3bdc4293f01d0, so I don't see any value in having any dependency to Apache HTTP components. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
