rzo1 commented on PR #2244: URL: https://github.com/apache/stormcrawler/pull/2244#issuecomment-6250205213
Thanks, looks good. On the routing question: I think that's acceptable for 4.0 and doesn't need a migration step. It only hits crawls that store Unicode hosts (the archetypes enable `hostIDNtoASCII`) and have status routing on, and #2122 already changed keys in the same way. Could you add a short note for the upgrade docs? It should cover the new routing, the `key` field in OpenSearch status documents and the `DomainParseFilter` value, which are all punycode now for these hosts. CI fails on formatting in `HostAliasCacheKeyTest.java`. Running `mvn git-code-format:format-code -Dskip.format.code=false` fixes it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
