suryakant-source opened a new pull request, #48:
URL: https://github.com/apache/stormcrawler-site/pull/48

   Fixes apache/stormcrawler#2254
   
   ## Problem
   The logo is not displayed in the published documentation (e.g. 
https://stormcrawler.apache.org/docs/latest/index.html): the docs header 
references `/img/logo.png`, which returns 404.
   
   ## Root cause
   The site restyle in #47 injected a `<header class="sc-docheader">` block 
into every versioned docs page with `<img class="logo-l" src="/img/logo.png">` 
for light mode, but the site only ships `img/logo-light.svg` and 
`img/logo-dark.svg`. The dark-mode reference (`/img/logo-dark.svg`) resolves 
fine; the light-mode one points to a file that does not exist, so the logo 
shows as a broken image in light mode.
   
   ## Solution
   Point the light-mode image at the existing `/img/logo-light.svg` — the same 
asset the main site header uses for light mode (`_includes/header.html`). 
Applied as the same one-line change to all 39 versioned docs pages: 
`docs/3.5.1` (9 files), `docs/3.6.0` (10), `docs/3.7.0` (10), and `docs/latest` 
(10).
   
   ## Testing
   - Verified live on https://stormcrawler.apache.org: `/img/logo.png` returns 
404 while `/img/logo-light.svg` returns 200 and is the asset served for the 
main site header in light mode.
   - Each changed page has exactly one modified line (the `logo-l` image 
`src`); no other content touched. Verified the resulting diff: 39 files 
changed, one line each.
   - I did not re-render the full Jekyll site locally; the docs pages are 
static HTML served as-is, and the referenced asset path was verified against 
the live site.
   
   ## Risk
   Low: a static HTML reference change only. The dark-mode logo 
(`logo-dark.svg`) and all documentation content are untouched.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to