jnioche commented on PR #2252: URL: https://github.com/apache/stormcrawler/pull/2252#issuecomment-6358565546
Thanks @rzo1! Addressed in abb97959: the exception is now passed as a throwable so the stack trace is kept (fixed the two existing "Error evaluating" calls too, and they now include the URL). Added a test that an invalid expression fails in `configure()`. Kept the early return in `LinkParseFilter` and added a comment: with no expressions, the old code only rebuilt the outlinks through a `HashMap`, which removed duplicates and changed their order, so leaving them untouched seems better. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
