jnioche commented on PR #2270: URL: https://github.com/apache/stormcrawler/pull/2270#issuecomment-6410166324
thanks @rzo1 mostly one comment / question / suggestion **core/src/main/java/org/apache/stormcrawler/shade/httpcore5/ (package name)** — “shade” does not feel right and collides with our own convention: external/solr/pom.xml:86 relocates into org.apache.stormcrawler.solr.shaded.org.eclipse.jetty, i.e. shaded means “maven-shade-plugin moved it”. Nothing shades these — they are hand-copied source. Rename to org.apache.stormcrawler.internal.httpcomponents (or .internal.http) now? a package name is frozen once 4.0.0 is out. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
