rzo1 opened a new pull request, #2321: URL: https://github.com/apache/stormcrawler/pull/2321
Stacked on #2320; I'll retarget it to `main` once that one is merged. The Storm 3.2.0 distribution ships these unshaded in `lib-common`, which comes before the topology jar on the worker classpath, so whatever copies a topology jar bundles are never loaded: - slf4j-api, commons-io, commons-codec, commons-compress, commons-lang3, jspecify - bouncycastle (bcprov, bcpkix, bcutil) and log4j-api, which come in through Tika - netty: buffer, codec, codec-base, codec-compression, codec-marshalling, codec-protobuf, common, handler, resolver, transport, transport-native-unix-common They are now `provided` in the root `dependencyManagement`, at the versions of the Storm 3.2.0 distribution, so they also drop out of the shaded and topology jars. The netty artifacts Storm doesn't ship (codec-http, codec-http2, the epoll classes) stay at compile scope, at the same version. No module now has one of the `lib-common` artifacts on its compile or runtime classpath. Two things to be aware of: - `provided` isn't transitive. Projects that use these libraries directly get them through `storm-client`, which they declare as provided anyway, as the archetypes do. - The versions now have to follow Storm's `lib-common` on every Storm upgrade. There's a comment in the pom saying so. `THIRD-PARTY.txt` doesn't change: the license plugin only excludes the `system` and `test` scopes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
