Great work Lasindu! Few comments inline: On Sat, Aug 2, 2014 at 9:49 PM, Lasindu Charith <[email protected]> wrote:
> Yet I have following concerns when it comes to Nodejs specific > applications. > > 1. The nodejs application itself defines the ports in use. This may > create problems in specifying the cartridge definition prior to the > deployment. The port to be listened has to be specified correctly in the > cartridge definition in order for a particular instance to be activated > properly. > > IMO this is not a problem. Cartridge definition anyway needs to define the ports. > > 1. Since we only can specify a single cartridge definition per service > type, all the ports which will be used by the nodejs application has to be > pre-defined/pre-known and at the time of defining the cartridge definition. > Also instance might hang up waiting, listing to the ports which are > currently not used. > > Not exactly. If required we can send the ports at the subscription time using payload parameters (if the instance can configure them accordingly). > > 1. Monitoring the health would also be difficult. > > What's problem we have here? We should be able to monitor the sockets I guess. > > 1. Deploying multiple applications using the same git repository could > be done. But will have to use a separate configuration file to specify > which/how to start those applications specifically. Also the necessary > ports have to be specified in the definition prior to the deployment. > > Our current design is to use a Git repository per application/subscription. > > > Please let me know any specifics/suggestions which I can use to overcome > the above issues. > > [1] https://forge.puppetlabs.com/puppetlabs/nodejs > [2] https://github.com/nodejitsu/forever > [3] https://github.com/Unitech/pm2 > > Thanks, > > -- Imesh Gunaratne Technical Lead, WSO2 Committer & PPMC Member, Apache Stratos
