[
https://issues.apache.org/jira/browse/STRATOS-749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14100272#comment-14100272
]
Chamila de Alwis commented on STRATOS-749:
------------------------------------------
Attached suggested fix as a .patch
> Redundant and unused variables in puppet3-agent/init.sh
> -------------------------------------------------------
>
> Key: STRATOS-749
> URL: https://issues.apache.org/jira/browse/STRATOS-749
> Project: Stratos
> Issue Type: Improvement
> Reporter: Chamila de Alwis
> Priority: Minor
> Attachments:
> 0001-Removed-unused-variables-in-init.sh-in-puppet-agent.patch
>
>
> Following variables seem to be unused after declaration.
> Line 38: PUPPETD=`which puppet` is declared and used subsequently in
> PUPPETAGENT and COMMAND. However when actually running the puppet agent at
> line 126 PUPPET is declared again and used to construct the puppet agent
> command.
> The method read_master() is also not used in the script.
> These can be removed for clarity since they are declared again when puppet
> agent command is actually used.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
