Thanks Isuru, I'll do the change.
On Thu, Aug 21, 2014 at 7:59 AM, Isuru Haththotuwa <[email protected]> wrote: > Hi, > > On Wed, Aug 20, 2014 at 8:28 PM, Nirmal Fernando <[email protected] > <[email protected]>> wrote: > >> By making all members of it, static. >> > >> >> On Wed, Aug 20, 2014 at 8:26 PM, Nirmal Fernando <[email protected]> >> wrote: >> >>> Thanks Isuru for the reply. Should we instantiate it at all then? Can't >>> we make it a static class? >>> >> A good idea Nirmal, +1. > >> >>> >>> On Wed, Aug 20, 2014 at 8:19 PM, Isuru Haththotuwa <[email protected]> >>> wrote: >>> >>>> Hi, >>>> >>>> On Wed, Aug 20, 2014 at 8:04 PM, Nirmal Fernando < >>>> [email protected]> wrote: >>>> >>>>> Hi, >>>>> >>>>> Is there any reason to not to make CartridgeSubscriptionManager a >>>>> Singleton class? As per current usage of that class, I feel it should be a >>>>> Singleton class. >>>>> >>>>> >>>>> https://github.com/apache/stratos/blob/master/components/org.apache.stratos.manager/src/main/java/org/apache/stratos/manager/manager/CartridgeSubscriptionManager.java >>>>> >>>> CartridgeSubscriptionManager does not store any global state or any >>>> information that should be available via only a single instance. Therefore, >>>> IMHO there is no specific requirement to make it a singleton. >>>> >>>>> >>>>> -- >>>>> Best Regards, >>>>> Nirmal >>>>> >>>>> Nirmal Fernando. >>>>> PPMC Member & Committer of Apache Stratos, >>>>> Senior Software Engineer, WSO2 Inc. >>>>> >>>>> Blog: http://nirmalfdo.blogspot.com/ >>>>> >>>>> -- >>>>> <http://nirmalfdo.blogspot.com/> >>>>> Thanks and Regards, >>>>> >>>>> Isuru H. >>>>> <http://nirmalfdo.blogspot.com/> >>>>> +94 716 358 048 <http://nirmalfdo.blogspot.com/>* <http://wso2.com/>* >>>>> >>>>> >>>>> * <http://wso2.com/>* >>>>> >>>>> >>>>> >>> >>> >>> -- >>> Best Regards, >>> Nirmal >>> >>> Nirmal Fernando. >>> PPMC Member & Committer of Apache Stratos, >>> Senior Software Engineer, WSO2 Inc. >>> >>> Blog: http://nirmalfdo.blogspot.com/ >>> >> >> >> >> -- >> Best Regards, >> Nirmal >> >> Nirmal Fernando. >> PPMC Member & Committer of Apache Stratos, >> Senior Software Engineer, WSO2 Inc. >> >> Blog: http://nirmalfdo.blogspot.com/ >> >> -- >> <http://nirmalfdo.blogspot.com/> >> Thanks and Regards, >> >> Isuru H. >> <http://nirmalfdo.blogspot.com/> >> +94 716 358 048 <http://nirmalfdo.blogspot.com/>* <http://wso2.com/>* >> >> >> * <http://wso2.com/>* >> >> >> -- Best Regards, Nirmal Nirmal Fernando. PPMC Member & Committer of Apache Stratos, Senior Software Engineer, WSO2 Inc. Blog: http://nirmalfdo.blogspot.com/
