Hi all, Thank you all for participating in the hangout and I learnt a lot from it.
You can find the hangout recording in [1 <https://www.youtube.com/watch?v=-Q1PLaeAX9I>] and the set of slides in [2 <https://docs.google.com/presentation/d/1mj3XMz4DNr-uPgYy0V9-cFZQbhW57aq4rcdtLz-4FeQ/edit?usp=sharing> ]. Below are few of the suggested changes in the review 1. Rename the 'Internal/user' role to something more meaningful. 2. Discuss on whether to divide add/delete/update permissions in to separate permission strings or to have all the above permissions to come under 'add' permission as it is. 3. Add a Class comment in StratosUserManager class and provide more descriptive method comments. 4. Discuss whether adding multiple roles should be allowed when creating a user in Stratos or not. I will be addressing the 1,3 in a new pull request. Regarding the suggestions 2,4 - they are easy to implement, but it's a matter of whether to include them in M1/M2 releases or not. May be we can discuss it here or later add it as an improvement. [1] https://www.youtube.com/watch?v=-Q1PLaeAX9I [2] https://docs.google.com/presentation/d/1mj3XMz4DNr-uPgYy0V9-cFZQbhW57aq4rcdtLz-4FeQ/edit?usp=sharing Thanks, On Tue, Sep 16, 2014 at 7:29 PM, Nirmal Fernando <[email protected]> wrote: > Please find the hangout link > https://plus.google.com/hangouts/_/hoaevent/AP36tYdpoBZNwhnmSJnbrrL6J1-i8uKt02zScLJwxuCogOYBGKsWVw?authuser=1&hl=en > > On Mon, Sep 15, 2014 at 10:40 PM, Lasindu Charith <[email protected]> > wrote: > >> >> Apache Stratos 4.1.0 User Management and Permissions - Design and Code >> Review >> <https://plus.google.com/_/notifications/ngemlink?&emid=COCQzPzN48ACFePtNAodcXQA4g&path=%2Fevents%2Fcaerufaj1falta5jhphgb0ntqc4%3Fauthkey%3DCK3k8ObFzJ-eGQ%26gpinv%3DAMIXal8bA6qUpEdrFwQSHi9P_1RK4EDhk_jXW4ttCZ83lt1ljW4EtpoZ8nKgL1FaDRUiHIg8bEgt1h0dZM6u98gkgTZzMCJo_xXyl-4-0RpCUm-bSGEyMGg%26gpsrc%3Dgpev0&dt=1410797428585&uob=14> >> <https://plus.google.com/_/notifications/ngemlink?&emid=COCQzPzN48ACFePtNAodcXQA4g&path=%2F103515557134069849802&dt=1410797428585&uob=14> >> Apache Stratos >> <https://plus.google.com/_/notifications/ngemlink?&emid=COCQzPzN48ACFePtNAodcXQA4g&path=%2F103515557134069849802&dt=1410797428585&uob=14> >> invited you to Apache Stratos 4.1.0 User Management and Permissions - >> Design and Code Review >> <https://plus.google.com/_/notifications/ngemlink?&emid=COCQzPzN48ACFePtNAodcXQA4g&path=%2Fevents%2Fcaerufaj1falta5jhphgb0ntqc4%3Fauthkey%3DCK3k8ObFzJ-eGQ%26gpinv%3DAMIXal8bA6qUpEdrFwQSHi9P_1RK4EDhk_jXW4ttCZ83lt1ljW4EtpoZ8nKgL1FaDRUiHIg8bEgt1h0dZM6u98gkgTZzMCJo_xXyl-4-0RpCUm-bSGEyMGg%26gpsrc%3Dgpev0&dt=1410797428585&uob=14> >> Tue, September 16, 7:30 PM GMT+5:30 >> Hangout >> <https://plus.google.com/_/notifications/ngemlink?&emid=COCQzPzN48ACFePtNAodcXQA4g&path=%2Fevents%2Fcaerufaj1falta5jhphgb0ntqc4%3Fauthkey%3DCK3k8ObFzJ-eGQ%26gpinv%3DAMIXal8bA6qUpEdrFwQSHi9P_1RK4EDhk_jXW4ttCZ83lt1ljW4EtpoZ8nKgL1FaDRUiHIg8bEgt1h0dZM6u98gkgTZzMCJo_xXyl-4-0RpCUm-bSGEyMGg%26gpsrc%3Dgpev0&dt=1410797428585&uob=14> >> Are you going? >> Yes >> <https://plus.google.com/_/notifications/ngemlink?&emid=COCQzPzN48ACFePtNAodcXQA4g&path=%2Fevents%2Fcaerufaj1falta5jhphgb0ntqc4%2Frsvp%2FCIjP9rjTusqPJw%2FATTENDING%3Fauthkey%3DCK3k8ObFzJ-eGQ%26gpinv%3DAMIXal8bA6qUpEdrFwQSHi9P_1RK4EDhk_jXW4ttCZ83lt1ljW4EtpoZ8nKgL1FaDRUiHIg8bEgt1h0dZM6u98gkgTZzMCJo_xXyl-4-0RpCUm-bSGEyMGg%26gpsrc%3Dgpev0&dt=1410797428585&uob=14> >> Maybe >> <https://plus.google.com/_/notifications/ngemlink?&emid=COCQzPzN48ACFePtNAodcXQA4g&path=%2Fevents%2Fcaerufaj1falta5jhphgb0ntqc4%2Frsvp%2FCIjP9rjTusqPJw%2FMAYBE%3Fauthkey%3DCK3k8ObFzJ-eGQ%26gpinv%3DAMIXal8bA6qUpEdrFwQSHi9P_1RK4EDhk_jXW4ttCZ83lt1ljW4EtpoZ8nKgL1FaDRUiHIg8bEgt1h0dZM6u98gkgTZzMCJo_xXyl-4-0RpCUm-bSGEyMGg%26gpsrc%3Dgpev0&dt=1410797428585&uob=14> >> No >> <https://plus.google.com/_/notifications/ngemlink?&emid=COCQzPzN48ACFePtNAodcXQA4g&path=%2Fevents%2Fcaerufaj1falta5jhphgb0ntqc4%2Frsvp%2FCIjP9rjTusqPJw%2FNOT_ATTENDING%3Fauthkey%3DCK3k8ObFzJ-eGQ%26gpinv%3DAMIXal8bA6qUpEdrFwQSHi9P_1RK4EDhk_jXW4ttCZ83lt1ljW4EtpoZ8nKgL1FaDRUiHIg8bEgt1h0dZM6u98gkgTZzMCJo_xXyl-4-0RpCUm-bSGEyMGg%26gpsrc%3Dgpev0&dt=1410797428585&uob=14> >> View Invitation >> <https://plus.google.com/_/notifications/ngemlink?&emid=COCQzPzN48ACFePtNAodcXQA4g&path=%2Fevents%2Fcaerufaj1falta5jhphgb0ntqc4%3Fauthkey%3DCK3k8ObFzJ-eGQ%26gpinv%3DAMIXal8bA6qUpEdrFwQSHi9P_1RK4EDhk_jXW4ttCZ83lt1ljW4EtpoZ8nKgL1FaDRUiHIg8bEgt1h0dZM6u98gkgTZzMCJo_xXyl-4-0RpCUm-bSGEyMGg%26gpsrc%3Dgpev0&dt=1410797428585&uob=14> >> Chris Haddad >> <https://plus.google.com/_/notifications/ngemlink?&emid=COCQzPzN48ACFePtNAodcXQA4g&path=%2F107027977075067366746&dt=1410797428585&uob=14>, >> Imesh Gunaratne >> <https://plus.google.com/_/notifications/ngemlink?&emid=COCQzPzN48ACFePtNAodcXQA4g&path=%2F100701010563689543643&dt=1410797428585&uob=14>, >> Deepal Jayasinghe >> <https://plus.google.com/_/notifications/ngemlink?&emid=COCQzPzN48ACFePtNAodcXQA4g&path=%2F111511500582133985308&dt=1410797428585&uob=14> >> and 47 more are invitedLasindu will discuss the design and >> implementation of the new User Management and Permission model for Apache >> Stratos 4.1.0 for public review. >> >> Currently in Stratos 4.0.0 there are only two user levels, namely super >> tenant and tenant admin. In Stratos 4.1.0, we are moving a step forward and >> start using the Carbon User Management feature to incorporate a more >> granular user management and permission model which is convenient to use. >> >> Tuesday 16th September 2014 (7.30 PM IST/ 7 AM PDT / 2 PM GMT) >> >> -- >> *Lasindu Charith* >> Software Engineer, WSO2 Inc. >> Mobile: +94714427192 >> Web: blog.lasindu.com >> > > > > -- > Best Regards, > Nirmal > > Nirmal Fernando. > PPMC Member & Committer of Apache Stratos, > Senior Software Engineer, WSO2 Inc. > > Blog: http://nirmalfdo.blogspot.com/ > -- *Lasindu Charith* Software Engineer, WSO2 Inc. Mobile: +94714427192 Web: blog.lasindu.com
