Great! Will group all issues together and fix. Thanks
On Wed, Oct 8, 2014 at 8:17 AM, Nirmal Fernando <[email protected]> wrote: > Yes, I've mentioned them in the commits not in the Jira. > > On Wed, Oct 8, 2014 at 8:15 AM, Imesh Gunaratne <[email protected]> wrote: > >> Yes we could do that. I can see you have fixed some of the problems in >> this issue, if we could mention the titles of the findings in this, I think >> it would be great. >> >> On Wed, Oct 8, 2014 at 7:59 AM, Nirmal Fernando (JIRA) <[email protected]> >> wrote: >> >>> >>> [ >>> https://issues.apache.org/jira/browse/STRATOS-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14162962#comment-14162962 >>> ] >>> >>> Nirmal Fernando commented on STRATOS-876: >>> ----------------------------------------- >>> >>> Hi Imesh, >>> >>> We already have a Jira to track Sonar reported critical issues [1]. >>> Should >>> we add these as sub tasks of that? >>> >>> [1] https://issues.apache.org/jira/browse/STRATOS-813 >>> >>> On Wed, Oct 8, 2014 at 7:51 AM, Imesh Gunaratne (JIRA) <[email protected]> >>> >>> >>> >>> >>> -- >>> Best Regards, >>> Nirmal >>> >>> Nirmal Fernando. >>> PPMC Member & Committer of Apache Stratos, >>> Senior Software Engineer, WSO2 Inc. >>> >>> Blog: http://nirmalfdo.blogspot.com/ >>> >>> >>> > [Sonar Findings] [Critical] A catch statement should never catch >>> throwable >>> > >>> -------------------------------------------------------------------------- >>> > >>> > Key: STRATOS-876 >>> > URL: https://issues.apache.org/jira/browse/STRATOS-876 >>> > Project: Stratos >>> > Issue Type: Improvement >>> > Reporter: Imesh Gunaratne >>> > >>> > A catch statement should never catch throwable since it includes >>> errors. >>> > https://analysis.apache.org/drilldown/issues/162219?severity=CRITICAL >>> >>> >>> >>> -- >>> This message was sent by Atlassian JIRA >>> (v6.3.4#6332) >>> >> >> >> >> -- >> Imesh Gunaratne >> >> Technical Lead, WSO2 >> Committer & PMC Member, Apache Stratos >> > > > > -- > Best Regards, > Nirmal > > Nirmal Fernando. > PPMC Member & Committer of Apache Stratos, > Senior Software Engineer, WSO2 Inc. > > Blog: http://nirmalfdo.blogspot.com/ > -- Imesh Gunaratne Technical Lead, WSO2 Committer & PMC Member, Apache Stratos
