Great work Shiro! Thanks for looking into this. On Thu, Nov 27, 2014 at 3:48 PM, Shiroshica Kulatilake <[email protected]> wrote:
> Hi Devs, > > The REST API refactoring is now on master. (commits > 2242e2fc6083129e3f0e5b08707250f5b1648a44, > 023900c4fdd7ba9b12a228b5bf619e77885a3f2f, > 72c9d60433d9b196d67268e850e572fd81a9fd97, > 6af9901141c9a89c44e76803b6cbdbb68561714c). > > The last commit consists of the changes that were required due to this > refactoring on the cli component. > > The next task in this would be to refactor the return codes / return body. > > Thank you, > Shiro > > On Tue, Nov 25, 2014 at 9:37 PM, Imesh Gunaratne <[email protected]> wrote: > >> Great work Shiro! >> >> On Tue, Nov 25, 2014 at 3:47 PM, Shiroshica Kulatilake <[email protected]> >> wrote: >> >>> >>> 1. Do we need to expose the method *updateKubernetesHost(KubernetesHost >>> kubernetesHost)* via the REST api ? >>> >> >> IMO we need to check the reason for maintaining Kubernetes host >> information in Stratos. >> >> 2. The *getServiceClusters(String cartridgeType)* method has been marked >>> deprecated - It is deprecated due to *getClustersOfCartridge( String >>> cartridgeType)* - since this is a new release should we remove this >>> completely ? >>> >>> May be we need to remove this. >> >> >> -- >> Imesh Gunaratne >> >> Technical Lead, WSO2 >> Committer & PMC Member, Apache Stratos >> > > > > -- > Shiroshica Kulatilake > > Architect, > WSO2, Inc. http://wso2.com/ > Phone: +94 776523867 > -- Imesh Gunaratne Technical Lead, WSO2 Committer & PMC Member, Apache Stratos
