Hi Mariangela, I think this will be OK since it is description of the commad. No need to have past tense(Removed) for the description of the command.
Thanks, Gayan On Mon, Jan 26, 2015 at 11:27 AM, Mariangela Hills <mariang...@wso2.com> wrote: > Sorry my IDE has not got updated. Btw, there is small a typo and grammar > mistake in the CLI response. I created a JIRA [1]. > > [1] https://issues.apache.org/jira/browse/STRATOS-1139 > > Regards, > Mariangela > > > > > *--* > Mariangela Hills > Senior Technical Writer > > *WSO2, Inc.*lean.enterprise.middleware. > w: http://wso2.com > <http://wso2.com/events/> > > On Mon, Jan 26, 2015 at 10:58 AM, Gayan Gunarathne <gay...@wso2.com> > wrote: > >> This is the commit ID :78fff3fc608afb8d9a6c665fe62308550a1da179 >> Commend file : DeleteAutoScalingPolicyCommand.java >> >> Thanks, >> Gayan >> >> >> On Mon, Jan 26, 2015 at 10:39 AM, Mariangela Hills <mariang...@wso2.com> >> wrote: >> >>> I didn't notice this in the latest code, which I checked out today. Has >>> this been committed to the latest code? >>> >>> Regards, >>> Mariangela >>> >>> >>> >>> >>> *--* >>> Mariangela Hills >>> Senior Technical Writer >>> >>> *WSO2, Inc.*lean.enterprise.middleware. >>> w: http://wso2.com >>> <http://wso2.com/events/> >>> >>> On Fri, Jan 23, 2015 at 5:10 PM, Gayan Gunarathne <gay...@wso2.com> >>> wrote: >>> >>>> Added new CLI command to remove auto-scaling policy. >>>> >>>> >remove-autoscaling-policy <autoscaling_policy_id> >>>> >>>> >>>> Thanks, >>>> Gayan >>>> >>>> On Thu, Jan 22, 2015 at 6:07 PM, Gayan Gunarathne <gay...@wso2.com> >>>> wrote: >>>> >>>>> Thanks Mariangela for reminding this. Currently don't have a CLI >>>>> command for this. I will add CLI command for auto-scaling policy removal. >>>>> >>>>> Thanks, >>>>> Gayan >>>>> >>>>> On Thu, Jan 22, 2015 at 5:56 PM, Mariangela Hills <mariang...@wso2.com >>>>> > wrote: >>>>> >>>>>> I added the REST API command to wiki [1]. >>>>>> >>>>>> Is there a corresponding CLI command for this? I check the code, but >>>>>> I didn't notice the command. >>>>>> >>>>>> [1] >>>>>> https://cwiki.apache.org/confluence/display/STRATOS/4.1.0+Deleting+an+Auto-scaling+Policy+via+REST+API >>>>>> >>>>>> Regards, >>>>>> Mariangela >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> *--* >>>>>> Mariangela Hills >>>>>> Senior Technical Writer >>>>>> >>>>>> *WSO2, Inc.*lean.enterprise.middleware. >>>>>> w: http://wso2.com >>>>>> <http://wso2.com/events/> >>>>>> >>>>>> On Thu, Jan 22, 2015 at 5:33 PM, Gayan Gunarathne <gay...@wso2.com> >>>>>> wrote: >>>>>> >>>>>>> Yeah. That's correct. >>>>>>> >>>>>>> Thanks, >>>>>>> Gayan >>>>>>> >>>>>>> On Thu, Jan 22, 2015 at 5:26 PM, Vishanth Balasubramaniam < >>>>>>> vishan...@wso2.com> wrote: >>>>>>> >>>>>>>> Hi Gayan, >>>>>>>> >>>>>>>> Is the following curl command correct to delete the autoscale >>>>>>>> policy ? >>>>>>>> >>>>>>>> curl -X DELETE -H "Content-Type: application/json" -k -v -u >>>>>>>>> admin:admin https:// >>>>>>>>> <stratos_ip>:9443/api/autoscalingPolicies/{autoscalePolicyId} >>>>>>>> >>>>>>>> >>>>>>>> Thanks, >>>>>>>> Vishanth >>>>>>>> >>>>>>>> On Thu, Jan 22, 2015 at 5:13 PM, Gayan Gunarathne <gay...@wso2.com> >>>>>>>> wrote: >>>>>>>> >>>>>>>>> Correction: >>>>>>>>> Rest API method to remove the Autoscaling policies will be like >>>>>>>>> this. >>>>>>>>> >>>>>>>>> HTTP MethodResource Path >>>>>>>>> >>>>>>>>> DELETE /autoscalingPolicies/{autoscalePolicyId} >>>>>>>>> <https://cwiki.apache.org/confluence/display/STRATOS/4.1.0+Describing+an+Auto-scaling+Policy+via+REST+API> >>>>>>>>> >>>>>>>>> >>>>>>>>> Thanks, >>>>>>>>> Gayan >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> On Thu, Jan 22, 2015 at 4:50 PM, Gayan Gunarathne <gay...@wso2.com >>>>>>>>> > wrote: >>>>>>>>> >>>>>>>>>> Updated the auto-scalar policy removal with validations.Also we >>>>>>>>>> have noticed that validations missing in the Application >>>>>>>>>> definition and deployment policy also. Added a JIRA(STRATOS-1096) >>>>>>>>>> for this and I will work on this. >>>>>>>>>> >>>>>>>>>> Thanks, >>>>>>>>>> Gayan >>>>>>>>>> >>>>>>>>>> On Wed, Jan 21, 2015 at 3:02 PM, Gayan Gunarathne < >>>>>>>>>> gay...@wso2.com> wrote: >>>>>>>>>> >>>>>>>>>>> Hi Udara, >>>>>>>>>>> >>>>>>>>>>> Yeah.I am adding those validations currently with validating >>>>>>>>>>> the auto-scale policy removal process. >>>>>>>>>>> >>>>>>>>>>> Thanks, >>>>>>>>>>> Gayan >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> On Wed, Jan 21, 2015 at 2:56 PM, Udara Liyanage <ud...@wso2.com> >>>>>>>>>>> wrote: >>>>>>>>>>> >>>>>>>>>>>> Hi Gayan, >>>>>>>>>>>> >>>>>>>>>>>> I glanced through the code. You need to return 404 when there >>>>>>>>>>>> is no policy exist with the given ID. Currently it returns only >>>>>>>>>>>> 200 OK. >>>>>>>>>>>> >>>>>>>>>>>> On Wed, Jan 21, 2015 at 11:55 AM, Gayan Gunarathne < >>>>>>>>>>>> gay...@wso2.com> wrote: >>>>>>>>>>>> >>>>>>>>>>>>> We have added new rest API method to remove the Autoscaling >>>>>>>>>>>>> policies(STRATOS-1090 >>>>>>>>>>>>> <https://issues.apache.org/jira/browse/STRATOS-1090>) >>>>>>>>>>>>> . >>>>>>>>>>>>> HTTP MethodResource Path >>>>>>>>>>>>> >>>>>>>>>>>>> DELETE /autoscalePolicies/{autoscalePolicyId} >>>>>>>>>>>>> <https://cwiki.apache.org/confluence/display/STRATOS/4.1.0+Describing+an+Auto-scaling+Policy+via+REST+API> >>>>>>>>>>>>> Related Commit IDs : >>>>>>>>>>>>> >>>>>>>>>>>>> aca5f2ec249f44a1765146aef51b876ce80ea28a/ef2838479a72ccda642e5a32318e29369c73c728 >>>>>>>>>>>>> >>>>>>>>>>>>> Currently I am working on the validating the auto-scale policy >>>>>>>>>>>>> removal process. >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> Thanks, >>>>>>>>>>>>> Gayan >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> -- >>>>>>>>>>>>> >>>>>>>>>>>>> Gayan Gunarathne >>>>>>>>>>>>> Technical Lead >>>>>>>>>>>>> WSO2 Inc. (http://wso2.com) >>>>>>>>>>>>> email : gay...@wso2.com | mobile : +94 766819985 >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> -- >>>>>>>>>>>> >>>>>>>>>>>> Udara Liyanage >>>>>>>>>>>> Software Engineer >>>>>>>>>>>> WSO2, Inc.: http://wso2.com >>>>>>>>>>>> lean. enterprise. middleware >>>>>>>>>>>> >>>>>>>>>>>> web: http://udaraliyanage.wordpress.com >>>>>>>>>>>> phone: +94 71 443 6897 >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> -- >>>>>>>>>>> >>>>>>>>>>> Gayan Gunarathne >>>>>>>>>>> Technical Lead >>>>>>>>>>> WSO2 Inc. (http://wso2.com) >>>>>>>>>>> email : gay...@wso2.com | mobile : +94 766819985 >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> >>>>>>>>>> Gayan Gunarathne >>>>>>>>>> Technical Lead >>>>>>>>>> WSO2 Inc. (http://wso2.com) >>>>>>>>>> email : gay...@wso2.com | mobile : +94 766819985 >>>>>>>>>> >>>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> >>>>>>>>> Gayan Gunarathne >>>>>>>>> Technical Lead >>>>>>>>> WSO2 Inc. (http://wso2.com) >>>>>>>>> email : gay...@wso2.com | mobile : +94 766819985 >>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> *Vishanth Balasubramaniam* >>>>>>>> Software Engineer >>>>>>>> WSO2 Inc.; http://wso2.com >>>>>>>> lean.enterprise.middleware >>>>>>>> >>>>>>>> mobile: *+94771737718* >>>>>>>> about me: *http://about.me/vishanth <http://about.me/vishanth>* >>>>>>>> >>>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> >>>>>>> Gayan Gunarathne >>>>>>> Technical Lead >>>>>>> WSO2 Inc. (http://wso2.com) >>>>>>> email : gay...@wso2.com | mobile : +94 766819985 >>>>>>> >>>>>>> >>>>>> >>>>>> >>>>> >>>>> >>>>> -- >>>>> >>>>> Gayan Gunarathne >>>>> Technical Lead >>>>> WSO2 Inc. (http://wso2.com) >>>>> email : gay...@wso2.com | mobile : +94 766819985 >>>>> >>>>> >>>> >>>> >>>> >>>> -- >>>> >>>> Gayan Gunarathne >>>> Technical Lead >>>> WSO2 Inc. (http://wso2.com) >>>> email : gay...@wso2.com | mobile : +94 766819985 >>>> >>>> >>> >>> >> >> >> -- >> >> Gayan Gunarathne >> Technical Lead >> WSO2 Inc. (http://wso2.com) >> email : gay...@wso2.com | mobile : +94 766819985 >> >> > > -- Gayan Gunarathne Technical Lead WSO2 Inc. (http://wso2.com) email : gay...@wso2.com | mobile : +94 766819985
