+1 . We should not comment out integration test.Yesterday I commented out that as temporary fix for build failure until we resolve the issues with integration testing module.
Thanks, Gayan On Fri, Feb 6, 2015 at 6:33 AM, Imesh Gunaratne <[email protected]> wrote: > I can see that Gayan has commented out the integration test to fix this, > IMO we should not comment out any tests when they fail. Jenkins does not > consider a test failure as a build failure rather it is reported as a build > instability. > > Therefore please do not comment out tests. We spent considerable amount of > effort to bring in these integration tests. If the tests fail we need to > fix the issue. I'm currently working on it. > > Thanks > > On Thu, Feb 5, 2015 at 9:47 PM, Imesh Gunaratne <[email protected]> wrote: > >> Thanks Vishanth, it works for me locally. I can see that the commit build >> also has raised this, I'm now investigating the cause of the problem. >> >> On Thu, Feb 5, 2015 at 8:17 PM, Vishanth Balasubramaniam < >> [email protected]> wrote: >> >>> Hi Imesh, >>> >>> I am getting this build failure. >>> >>> Failed tests: >>> testSingleCartridgeApplication(org.apache.stratos.integration.tests.SampleApplicationTests): >>> Application is not found: [application-id] single-cartridge-app >>> >>> Thank you, >>> Vishanth >>> >>> On Thu, Feb 5, 2015 at 7:44 PM, Imesh Gunaratne <[email protected]> >>> wrote: >>> >>>> Hi Devs, >>>> >>>> I have now refined above test classes and added single cartridge sample >>>> application integration test to the stratos product build. >>>> >>>> Thanks >>>> >>>> On Tue, Feb 3, 2015 at 6:16 PM, Gayan Gunarathne <[email protected]> >>>> wrote: >>>> >>>>> Great work Imesh. >>>>> >>>>> I am starting to update the single-group-v2 and single-group-v3 >>>>> samples in line with the automation integration tests. >>>>> >>>>> Thanks, >>>>> Gayan >>>>> >>>>> On Mon, Feb 2, 2015 at 11:45 PM, Imesh Gunaratne <[email protected]> >>>>> wrote: >>>>> >>>>>> Hi Devs, >>>>>> >>>>>> I have now implemented an automated integration test server manager >>>>>> module which can configure and start ActiveMQ and Stratos instances for >>>>>> deploying sample applications [1]. >>>>>> >>>>>> As the first step I have written an integration test to verify >>>>>> single-cartridge sample application [2]. >>>>>> >>>>>> Please note that I will be away for two days. If anyone would like to >>>>>> contribute to implement more tests covering other sample applications >>>>>> please feel free to do so. >>>>>> >>>>>> [1] >>>>>> https://github.com/apache/stratos/blob/master/products/stratos/modules/integration/src/test/java/org/apache/stratos/integration/tests/StratosTestServerManager.java >>>>>> [2] >>>>>> https://github.com/apache/stratos/blob/master/products/stratos/modules/integration/src/test/java/org/apache/stratos/integration/tests/SampleApplicationTests.java >>>>>> >>>>>> Many Thanks >>>>>> >>>>>> >>>>>> -- >>>>>> Imesh Gunaratne >>>>>> >>>>>> Technical Lead, WSO2 >>>>>> Committer & PMC Member, Apache Stratos >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> >>>>> Gayan Gunarathne >>>>> Technical Lead >>>>> WSO2 Inc. (http://wso2.com) >>>>> email : [email protected] | mobile : +94 766819985 >>>>> >>>>> >>>> >>>> >>>> >>>> -- >>>> Imesh Gunaratne >>>> >>>> Technical Lead, WSO2 >>>> Committer & PMC Member, Apache Stratos >>>> >>> >>> >>> >>> -- >>> *Vishanth Balasubramaniam* >>> Software Engineer >>> WSO2 Inc.; http://wso2.com >>> lean.enterprise.middleware >>> >>> mobile: *+94771737718* >>> about me: *http://about.me/vishanth <http://about.me/vishanth>* >>> >>> >> >> >> -- >> Imesh Gunaratne >> >> Technical Lead, WSO2 >> Committer & PMC Member, Apache Stratos >> > > > > -- > Imesh Gunaratne > > Technical Lead, WSO2 > Committer & PMC Member, Apache Stratos > -- Gayan Gunarathne Technical Lead WSO2 Inc. (http://wso2.com) email : [email protected] | mobile : +94 766819985
