Hi,

In the Java cartridge agent there is an unused class, ArifactCopyTask
class, which seems to be copying a given source folder to a given
destination. It is evident from the commented out code that this was used
to copy repository artifacts from a temporary location to the super tenant
application path. Isn't this now handled by the GitBasedArtifactRepository
class? It derives the proper application path by checking if the cartridge
is single or multi tenant one.

Additionally another class named RepositoryFileListener seems to be an
obsolete implementation of the auto commit functionality, which is also
handled by the GitBasedArtifactRepository class.

Can these classes and commented out code be safely removed from the JCA?

Regards,
Chamila de Alwis
Software Engineer | WSO2 | +94772207163
Blog: code.chamiladealwis.com

Reply via email to