Hi Martin, The way that the WKA scheme was handled in the deleted code was not extensible, and that was the reason these code segments were removed from the DefaultExtensionHandler. They are intended to be handled by Cartridge Agent plugins which are plug-gable through the orchestration method (Puppet or Docker) for different types of cartridges.
Regards, Chamila de Alwis Software Engineer | WSO2 | +94772207163 Blog: code.chamiladealwis.com On Wed, Mar 18, 2015 at 12:53 AM, Martin Eppel (meppel) <[email protected]> wrote: > Attaching the diff for DefaultExtensionHandler.java between 4.1.0 and > 4.0.0 (--- 4.0.0, +++ 4.1.0) > > > > Thanks > > > > Martin > > > > *From:* Martin Eppel (meppel) > *Sent:* Tuesday, March 17, 2015 11:21 AM > *To:* [email protected] > *Subject:* DISCUSS: JIRA STRATOS-697support in 4.1 ? > > > > I noticed that the code which resolved the JIRA STRATOS-697 seems to be > missing in 4.1. This JIRA supports clustering and WKA member handling in > Stratos. > > > > I am not sure if it is still required or not ? > > > > STRATOS-697 introduced in the JCA the class DefaultExtensionHandler.java > which is there in 4.0.0 and 4.1.0 . However, some code in > DefaultExtensionHandleris missing in 4.1, for instance: > > > > In 4.0.0 DefaultExtensionHandler references lb enhancements ( missing in > 4.1): > > > > *…* > > *String lbClusterId = > cluster.getMember(memberActivatedEvent.getMemberId()).getLbClusterId();* > > *…* > > > > *// check whether member activated event is received from the same > cluster, lbcluster or service group* > > * if > (ExtensionUtils.isRelevantMemberEvent(memberActivatedEvent.getServiceName(), > memberActivatedEvent.getClusterId(), lbClusterId)) {* > > * Map<String, String> env = new HashMap<String, String>();* > > * env.put("STRATOS_MEMBER_ACTIVATED_MEMBER_IP", > memberActivatedEvent.getMemberIp());* > > * env.put("STRATOS_MEMBER_ACTIVATED_MEMBER_ID", > memberActivatedEvent.getMemberId());* > > * env.put("STRATOS_MEMBER_ACTIVATED_CLUSTER_ID", > memberActivatedEvent.getClusterId());* > > * env.put("STRATOS_MEMBER_ACTIVATED_LB_CLUSTER_ID", > lbClusterId);* > > *…* > > In ExtensionUtils.java > > *…* > > *public static boolean isRelevantMemberEvent(String serviceName, String > clusterId, String lbClusterId) {* > > *…* > > > > > > In think the question is if code changes for JIRA STRATOS-697 are still > need to be supported in 4.1 or not and were missed to be ported to 4.1 or > were implemented differently – same question might apply to JPA ? > > > > Thanks > > > > Martin > > >
