I think we can stick to [1] as it is based on the HTTP status code standard.
[1] https://cwiki.apache.org/confluence/display/STRATOS/HTTP+Status+Codes [2] http://en.wikipedia.org/wiki/List_of_HTTP_status_codes Regards, Mariangela *--* Mariangela Hills Senior Technical Writer *WSO2, Inc.*lean.enterprise.middleware. m: +94 773 500185 w: http://wso2.com <http://wso2.com/events/> On Mon, Mar 23, 2015 at 9:44 AM, Udara Liyanage <[email protected]> wrote: > Hi Mari, > > There were many 201 , 200 mismatch your have reported. I fixed them. > However we need to have a proper ways of deciding on return status codes > depending on PUT,DELETE, GET. There are some inconsistencies now. May be we > can have a review after beta. > > On Mon, Mar 23, 2015 at 9:40 AM, Mariangela Hills <[email protected]> > wrote: > >> Thanks, Imesh! I will check this. >> >> Regards, >> Mariangela >> >> >> >> >> *--* >> Mariangela Hills >> Senior Technical Writer >> >> *WSO2, Inc.*lean.enterprise.middleware. >> m: +94 773 500185 >> w: http://wso2.com >> <http://wso2.com/events/> >> >> On Sat, Mar 21, 2015 at 9:12 AM, Imesh Gunaratne <[email protected]> >> wrote: >> >>> I have now fixed this and pushed changes to master branch. Please try >>> again. >>> >>> Thanks >>> >>> On Sat, Mar 21, 2015 at 8:46 AM, Imesh Gunaratne <[email protected]> >>> wrote: >>> >>>> Thanks Mari for pointing this! Yes it should return 404, I will fix >>>> this. >>>> >>>> On Sat, Mar 21, 2015 at 8:22 AM, Mariangela Hills <[email protected]> >>>> wrote: >>>> >>>>> Hi Devs, >>>>> >>>>> Is it correct that the HTTP status code 400 is returned when a user >>>>> searches for a deployment policy that has not been added [1]? Shouldn't >>>>> this be 404? >>>>> >>>>> [1] >>>>> Admin16s-MacBook-Air:samples Admin16$ curl -X GET -H "Content-Type: >>>>> application/json" -k -v -u admin:admin >>>>> https://localhost:9443/api/deploymentPolicies/deployment-policy-6 >>>>> * About to connect() to localhost port 9443 (#0) >>>>> * Trying ::1... >>>>> * connected >>>>> * Connected to localhost (::1) port 9443 (#0) >>>>> * SSLv3, TLS handshake, Client hello (1): >>>>> * SSLv3, TLS handshake, Server hello (2): >>>>> * SSLv3, TLS handshake, CERT (11): >>>>> * SSLv3, TLS handshake, Server key exchange (12): >>>>> * SSLv3, TLS handshake, Server finished (14): >>>>> * SSLv3, TLS handshake, Client key exchange (16): >>>>> * SSLv3, TLS change cipher, Client hello (1): >>>>> * SSLv3, TLS handshake, Finished (20): >>>>> * SSLv3, TLS change cipher, Client hello (1): >>>>> * SSLv3, TLS handshake, Finished (20): >>>>> * SSL connection using DHE-RSA-AES256-SHA >>>>> * Server certificate: >>>>> * subject: C=US; ST=CA; L=Mountain View; O=WSO2; CN=localhost >>>>> * start date: 2010-02-19 07:02:26 GMT >>>>> * expire date: 2035-02-13 07:02:26 GMT >>>>> * common name: localhost (matched) >>>>> * issuer: C=US; ST=CA; L=Mountain View; O=WSO2; CN=localhost >>>>> * SSL certificate verify result: unable to get local issuer >>>>> certificate (20), continuing anyway. >>>>> * Server auth using Basic with user 'admin' >>>>> > GET /api/deploymentPolicies/deployment-policy-6 HTTP/1.1 >>>>> > Authorization: Basic YWRtaW46YWRtaW4= >>>>> > User-Agent: curl/7.24.0 (x86_64-apple-darwin12.0) libcurl/7.24.0 >>>>> OpenSSL/0.9.8| zlib/1.2.5 >>>>> > Host: localhost:9443 >>>>> > Accept: */* >>>>> > Content-Type: application/json >>>>> > >>>>> < HTTP/1.1 400 Bad Request >>>>> < Date: Sat, 21 Mar 2015 02:46:15 GMT >>>>> < Content-Type: application/json >>>>> < Transfer-Encoding: chunked >>>>> < Connection: close >>>>> < Server: WSO2 Carbon Server >>>>> < >>>>> * Closing connection #0 >>>>> >>>>> >>>>> >>>>> >>>>> Regards, >>>>> Mariangela >>>>> >>>>> >>>>> >>>>> >>>>> *--* >>>>> Mariangela Hills >>>>> Senior Technical Writer >>>>> >>>>> *WSO2, Inc.*lean.enterprise.middleware. >>>>> w: http://wso2.com >>>>> >>>>> >>>> >>>> >>>> -- >>>> Imesh Gunaratne >>>> >>>> Technical Lead, WSO2 >>>> Committer & PMC Member, Apache Stratos >>>> >>> >>> >>> >>> -- >>> Imesh Gunaratne >>> >>> Technical Lead, WSO2 >>> Committer & PMC Member, Apache Stratos >>> >> >> > > > -- > > Udara Liyanage > Software Engineer > WSO2, Inc.: http://wso2.com > lean. enterprise. middleware > > web: http://udaraliyanage.wordpress.com > phone: +94 71 443 6897 >
