Great! Nice to hear that! May be these changes can be included in 4.1.3. On Tue, Sep 1, 2015 at 2:13 AM, Akila Ravihansa Perera <raviha...@wso2.com> wrote:
> Hi, > > I found the issue with PCA which prevented it from being started inside > 'modules' dir. This is because we have hard-coded 'modules' in PCA to get > the absolute path of certain artifacts. I've fixed this and moved PCA > product sub-modules to a sub directory named 'modules'. Now all product > distributions have the same folder structure. > > Thanks. > > On Sun, Aug 30, 2015 at 3:03 PM, Akila Ravihansa Perera < > raviha...@wso2.com> wrote: > >> This is now fixed in stratos-4.1.x branch. I've restructured Stratos >> extensions in the same manner. >> >> On Sun, Aug 30, 2015 at 1:00 AM, Imesh Gunaratne <im...@apache.org> >> wrote: >> >>> Right, then it should be fine! Yes +1 for moving the integrations tests >>> to the product. >>> >>> Thanks >>> >>> On Sun, Aug 30, 2015 at 12:17 AM, Akila Ravihansa Perera < >>> raviha...@wso2.com> wrote: >>> >>>> Hi Imesh, >>>> >>>> I had to change the pattern for PCA since there is a strange issue with >>>> running Python programs under a sub-directory named 'modules' which is very >>>> strange. I didn't want to keep the tests in PCA component because we need >>>> to check the actual distribution in integration tests. I'm planning to add >>>> more unit tests to PCA component. >>>> >>>> Regarding CLI, I'll move sub modules to a 'modules' dir. >>>> >>>> Thanks. >>>> >>>> On Sun, Aug 30, 2015 at 12:09 AM, Imesh Gunaratne <im...@apache.org> >>>> wrote: >>>> >>>>> Hi Devs, >>>>> >>>>> I think we need to follow the same convention we are following for >>>>> other distributions [1], [2] for $subject, currently it does not have a >>>>> modules folder [2]. This problem is also there in the CLI [4]. >>>>> >>>>> [1] >>>>> https://github.com/apache/stratos/tree/stratos-4.1.x/products/stratos/modules >>>>> [2] >>>>> https://github.com/apache/stratos/tree/stratos-4.1.x/products/load-balancer/modules >>>>> [3] >>>>> https://github.com/apache/stratos/tree/stratos-4.1.x/products/python-cartridge-agent >>>>> [4] >>>>> https://github.com/apache/stratos/tree/stratos-4.1.x/products/stratos-cli >>>>> >>>>> Thanks >>>>> >>>>> -- >>>>> Imesh Gunaratne >>>>> >>>>> Senior Technical Lead, WSO2 >>>>> Committer & PMC Member, Apache Stratos >>>>> >>>> >>>> >>>> >>>> -- >>>> Akila Ravihansa Perera >>>> WSO2 Inc.; http://wso2.com/ >>>> >>>> Blog: http://ravihansa3000.blogspot.com >>>> >>> >>> >>> >>> -- >>> Imesh Gunaratne >>> >>> Senior Technical Lead, WSO2 >>> Committer & PMC Member, Apache Stratos >>> >> >> >> >> -- >> Akila Ravihansa Perera >> WSO2 Inc.; http://wso2.com/ >> >> Blog: http://ravihansa3000.blogspot.com >> > > > > -- > Akila Ravihansa Perera > WSO2 Inc.; http://wso2.com/ > > Blog: http://ravihansa3000.blogspot.com > -- Imesh Gunaratne Senior Technical Lead, WSO2 Committer & PMC Member, Apache Stratos
