+1 for cleaning pom.xml files, I could not think of any problem of keeping license header in each file.
Thanks On Mon, Aug 12, 2013 at 12:35 PM, Manula Chathurika Thantriwatte < [email protected]> wrote: > +1 > > > > > On Mon, Aug 12, 2013 at 12:05 PM, Isuru Perera <[email protected]> wrote: > >> Hi all, >> >> I have added Apache Parent POM to the root pom.xml [1]. >> >> With that I added license, scm details etc. to root pom.xml. >> >> But we still have <license> defined in some child pom.xml files. For >> example check: >> grep -A 3 -R '<license>' . --include=pom.xml >> >> I think we should remove those and keep license only in root pom. Or >> should we add it to every POM? >> >> <scm> tag is also there in some pom.xml and those are invalid. See: >> grep -A 4 -R '<scm>' . --include=pom.xml >> >> Likewise there are many things need to be cleaned up. >> >> Some more things to check: >> grep -A 4 -R '<issueManagement>' . --include=pom.xml >> grep -A 7 -R '<mailingLists>' . --include=pom.xml >> grep -A 3 -R '<organization>' . --include=pom.xml >> grep -A 3 -R '<repositories>' . --include=pom.xml >> >> I think we should keep general things only in root pom. >> >> Please share your suggestions. >> >> Thanks! >> >> [1] https://issues.apache.org/jira/browse/STRATOS-44 >> >> -- >> Isuru Perera >> Senior Software Engineer | WSO2, Inc. | http://wso2.com/ >> Lean . Enterprise . Middleware >> >> Twitter: http://twitter.com/chrishantha | LinkedIn: >> http://lk.linkedin.com/in/chrishantha/ >> > > > > -- > Regards, > Manula Chathurika Thantriwatte > Software Engineer > WSO2 Inc. : http://wso2.com > lean . enterprise . middleware > > email : [email protected] / [email protected] > phone : +94 772492511 > blog : http://manulachathurika.blogspot.com/ > > > > -- *Imesh Gunaratne* Technical Lead WSO2 Inc | http://wso2.com Mobile: +94 77 374 2057 Blog: http://imesh.gunaratne.org Lean . Enterprise . Middleware
