+1 for the new property! On Jan 18, 2014 1:27 AM, "Lakmal Warusawithana" <[email protected]> wrote:
> Hi Nirnal, > > I think we can use "Cartridge Category" property to identify LB cartridge. > That means we have 4 type of cartridges > > 1. Application Cartridge - (e.g wordpress, drupal .etc - which does > not required external artifact repo) > 2. Data cartridge (e.g. MySQL, Mongo .etc - which does not required > external artifact repo) > 3. Framework cartridge (e.g. PHP, Ruby, Node.js .etc - which required > external artifact repo) > 4. LB cartridge (e.g Stratos LB, HAProxy LB - which does not required > external artifact repo) > > thanks > > > On Sat, Jan 18, 2014 at 11:13 AM, Nirmal Fernando > <[email protected]>wrote: > >> To be clear, concern I raised was to the idea of creating elements in >> order to recognize whether it's a lb Cartridge (eg: isLoadBalancer or >> something). If we're to go this path we'll end up adding whole lot of >> elements to the config, to detect whether it's a data Cartridge and so on. >> >> I'm +1 for defining a general property. But not sure how practical it is. >> >> >> On Sat, Jan 18, 2014 at 11:06 AM, Lahiru Sandaruwan <[email protected]>wrote: >> >>> Hi, >>> >>> Sent from my mobile. >>> >>> On Jan 17, 2014 1:18 PM, "damitha kumarage" <[email protected]> wrote: >>> > >>> > Hi Nirmal, >>> > IMHO it is not a bad idea to promote an optional property to a >>> mandatory property if it is deemed such promotion is necessary. However >>> such changes desired to be infrequent and can be allowed between major >>> versions. >>> >>> +1. This is an important property. Specially when we have more cartridge >>> types as Isuru mentioned. Then we can't check if it's there or not. We have >>> to know which type is it. >>> So +1 for mandating this. >>> >>> Thanks. >>> >>> > >>> > Damitha >>> > >>> > >>> > On Fri, Jan 17, 2014 at 8:49 AM, Nirmal Fernando < >>> [email protected]> wrote: >>> >> >>> >> Isuru, >>> >> >>> >> Problem I see here is, if we follow the same structure, we have to >>> keep adding new elements to the configuration, which would make it complex >>> to configure. So, IMO we should keep using properties (since these are >>> optional elements) leveraging the extensibility of the Cartridge definition >>> file and correctly document them all. >>> >> >>> >> >>> >> On Thu, Jan 16, 2014 at 11:17 PM, Isuru Haththotuwa <[email protected]> >>> wrote: >>> >>> >>> >>> Hi Devs, >>> >>> >>> >>> >>> >>> Currently it seems that identifying a LB cartridge is done using a >>> property in cartridge definition ("name": "load.balancer", "value": >>> "true"). The Autoscaler looks at this to decide whether to assign a normal >>> Cluster Monitor or a LB Cluster Monitor. If this property is not available, >>> there is no way to do this. >>> >> >>> >> >>> >> Well, the logic should be corrected (if it's not already there) to >>> assume the value of this property as false by default. So, if you didn't >>> specify it explicitly, its value still be false. >>> >> >>> >>> >>> >>> IMHO, we should not add this as a property, but as a mandatory >>> field. WDYT of adding a unique property to identify the LB cartridge? >>> Furthermore, we could extend this approach to uniquely identify the four >>> basic cartridge categories as previously discussed in the mail thread with >>> subject [1]. >>> >>> >>> >>> [1]. A Better Model for Generic Types of Cartridges >>> >>> >>> >>> >>> >>> -- >>> >>> Thanks and Regards, >>> >>> >>> >>> Isuru H. >>> >>> +94 716 358 048 >>> >>> >>> >>> >>> >> >>> >> >>> >> >>> >> -- >>> >> Best Regards, >>> >> Nirmal >>> >> >>> >> Nirmal Fernando. >>> >> PPMC Member & Committer of Apache Stratos, >>> >> Senior Software Engineer, WSO2 Inc. >>> >> >>> >> Blog: http://nirmalfdo.blogspot.com/ >>> > >>> > >>> > >>> > >>> > -- >>> > __________________________________________________________________ >>> > Damitha Kumarage >>> > http://people.apache.org/ >>> > __________________________________________________________________ >>> >>> >> >> >> -- >> Best Regards, >> Nirmal >> >> Nirmal Fernando. >> PPMC Member & Committer of Apache Stratos, >> Senior Software Engineer, WSO2 Inc. >> >> Blog: http://nirmalfdo.blogspot.com/ >> > > > > -- > Lakmal Warusawithana > Software Architect; WSO2 Inc. > Mobile : +94714289692 > Blog : http://lakmalsview.blogspot.com/ > >
