On Tue, Apr 15, 2014 at 12:35 PM, chris snow <[email protected]> wrote:
> I've got some feedback on the PR process (below). It seems as though > we will get instructions in the email notification of the PR, so as > soon as the JIRA ticket is resolved we are good to go. > > > +1, IMO we also can go same process > ---------- Forwarded message ---------- > > Hi Sebastien, > > > > I was hoping you may be able to help us on the Apache Stratos project > > with our github and apache integration. > > > > We would like to merge and close Stratos github pull requests similar > > to the process you use for cloudstack-docs. > > > > - What process do you use for merging and closing github PRs? > > Basically when you get the notification that there was a PR, you get > instructions in the email. > > what has worked for me is to wget the patch , test it , commit it then > amend the commit message with a "Closes #<number of the PR>" and push > to the ASF git repo. > Once the ASF repo gets mirrored in github, it will automatically close > the pull request. > > You will not get access to the MERGE button on github, which is probably > good. > > > > - Did you need INFRA to perform any special setup to support this > process? > > > > Yes, you need to ask them to "turn it on", either by opening an > [INFRA] ticket on jira or asking them on IRC: asfinfra > it's usually a 1 minute thing. they did it over IRC for me. > > ---------- > > On Tue, Apr 15, 2014 at 7:09 AM, chris snow <[email protected]> wrote: > > Hi Isuru, the JIRA ticket will just enable PR's to be emailed to the > > dev mailing list. > > > > I couldn't find any info on what needs to be done to accept PR's, so > > I've emailed the guy who setup github for cloudstack-docs to ask him > > he did. > > > > On Tue, Apr 15, 2014 at 6:18 AM, Isuru Perera <[email protected]> wrote: > >> Thanks Chris for creating the JIRA. > >> > >> Also Thanks Nirmal for checking on this! :) > >> > >> I hope we can accept PRs instead of patches now. > >> > >> > >> On Tue, Apr 15, 2014 at 9:20 AM, Nirmal Fernando < > [email protected]> > >> wrote: > >>> > >>> Neither me Chris... so probably we don't need a vote :-) Thanks for > >>> creating the Infra jira. > >>> > >>> > >>> On Tue, Apr 15, 2014 at 9:09 AM, chris snow <[email protected]> > wrote: > >>>> > >>>> I haven't seen anything, I just wasn't sure what the normal process > was. > >>>> > >>>> Ticket created: https://issues.apache.org/jira/browse/INFRA-7580 > >>>> > >>>> On Mon, Apr 14, 2014 at 11:02 PM, Nirmal Fernando > >>>> <[email protected]> wrote: > >>>> > I don't think we need a vote... is there a place which say so? > >>>> > > >>>> > > >>>> > On Tue, Apr 15, 2014 at 3:06 AM, chris snow <[email protected]> > >>>> > wrote: > >>>> >> > >>>> >> I'm wondering as a starting point if we should get github PRs sent > to > >>>> >> [email protected], similar to what was requested > for > >>>> >> cloudstack-docs: > >>>> >> > >>>> >> https://issues.apache.org/jira/browse/INFRA-7273 > >>>> >> > >>>> >> Do we need to vote on this, or shall I go ahead and create a JIRA > >>>> >> ticket? > >>>> >> > >>>> >> On Mon, Apr 14, 2014 at 10:05 PM, Nirmal Fernando > >>>> >> <[email protected]> wrote: > >>>> >> > Great.. thanks. > >>>> >> > > >>>> >> > > >>>> >> > On Tue, Apr 15, 2014 at 2:34 AM, chris snow <[email protected] > > > >>>> >> > wrote: > >>>> >> >> > >>>> >> >> Will do. I'll post back here when I have some more info. > >>>> >> >> > >>>> >> >> On Mon, Apr 14, 2014 at 10:00 PM, Nirmal Fernando > >>>> >> >> <[email protected]> wrote: > >>>> >> >> > Thanks Chris. Would you be able to find some time to follow > that > >>>> >> >> > up? > >>>> >> >> > > >>>> >> >> > > >>>> >> >> > On Tue, Apr 15, 2014 at 2:27 AM, chris snow < > [email protected]> > >>>> >> >> > wrote: > >>>> >> >> >> > >>>> >> >> >> Hi Nirmal, I've closed the PR on Github. > >>>> >> >> >> > >>>> >> >> >> I also found this blog about tigher integration: > >>>> >> >> >> > >>>> >> >> >> > >>>> >> >> >> > >>>> >> >> >> > >>>> >> >> >> > https://blogs.apache.org/infra/entry/improved_integration_between_apache_and > >>>> >> >> >> > >>>> >> >> >> On Mon, Apr 14, 2014 at 9:51 PM, Nirmal Fernando > >>>> >> >> >> <[email protected]> > >>>> >> >> >> wrote: > >>>> >> >> >> > Reviewing and applying a GIT pull request > >>>> >> >> >> > > >>>> >> >> >> > Checkout github repository: > >>>> >> >> >> > https://github.com/apache/incubator-stratos.git > >>>> >> >> >> > > >>>> >> >> >> > Add ASF as a remote branch > >>>> >> >> >> > > >>>> >> >> >> > $ git remote add apache > >>>> >> >> >> > > https://git-wip-us.apache.org/repos/asf/incubator-stratos.git > >>>> >> >> >> > $ git fetch apache > >>>> >> >> >> > $ git checkout -b apache apache/master > >>>> >> >> >> > > >>>> >> >> >> > Checking out git pull request eg: pull request number 3 to > a > >>>> >> >> >> > new > >>>> >> >> >> > branch; > >>>> >> >> >> > > >>>> >> >> >> > > >>>> >> >> >> > $ git fetch origin pull/3/head:pr-3 > >>>> >> >> >> > $ git checkout pr-3 > >>>> >> >> >> > > >>>> >> >> >> > > >>>> >> >> >> > Review the pull request. > >>>> >> >> >> > > >>>> >> >> >> > Pushing changes: > >>>> >> >> >> > > >>>> >> >> >> > $ git rebase -i apache > >>>> >> >> >> > $ git checkout apache > >>>> >> >> >> > $ git merge pr-3 > >>>> >> >> >> > $ git push apache refs/heads/apache:master > >>>> >> >> >> > > >>>> >> >> >> > > >>>> >> >> >> > > >>>> >> >> >> > > >>>> >> >> >> > On Tue, Apr 15, 2014 at 2:11 AM, Nirmal Fernando > >>>> >> >> >> > <[email protected]> > >>>> >> >> >> > wrote: > >>>> >> >> >> >> > >>>> >> >> >> >> Can you please check whether you can close the pull > request? > >>>> >> >> >> >> > >>>> >> >> >> >> > >>>> >> >> >> >> On Tue, Apr 15, 2014 at 2:09 AM, Nirmal Fernando > >>>> >> >> >> >> <[email protected]> > >>>> >> >> >> >> wrote: > >>>> >> >> >> >>> > >>>> >> >> >> >>> Hi Chris, > >>>> >> >> >> >>> > >>>> >> >> >> >>> I think I've successfully merged your pull request. I'll > >>>> >> >> >> >>> come up > >>>> >> >> >> >>> with > >>>> >> >> >> >>> a > >>>> >> >> >> >>> set of steps, so that we can add it to a wiki page. > >>>> >> >> >> >>> > >>>> >> >> >> >>> > >>>> >> >> >> >>> On Tue, Apr 15, 2014 at 12:56 AM, chris snow > >>>> >> >> >> >>> <[email protected]> > >>>> >> >> >> >>> wrote: > >>>> >> >> >> >>>> > >>>> >> >> >> >>>> Hi Isuru, > >>>> >> >> >> >>>> > >>>> >> >> >> >>>> Did you find out what the situation is regarding Pull > >>>> >> >> >> >>>> Requests? > >>>> >> >> >> >>>> > >>>> >> >> >> >>>> I've just added a test PR: > >>>> >> >> >> >>>> https://github.com/apache/incubator-stratos/pull/3 > >>>> >> >> >> >>>> > >>>> >> >> >> >>>> Many thanks, > >>>> >> >> >> >>>> > >>>> >> >> >> >>>> Chris > >>>> >> >> >> >>>> > >>>> >> >> >> >>>> > >>>> >> >> >> >>>> On Sat, Apr 12, 2014 at 12:41 PM, Isuru Perera > >>>> >> >> >> >>>> <[email protected]> > >>>> >> >> >> >>>> wrote: > >>>> >> >> >> >>>> > Hi Devs, > >>>> >> >> >> >>>> > > >>>> >> >> >> >>>> > Does anyone know whether we can accept pull requests. > >>>> >> >> >> >>>> > > >>>> >> >> >> >>>> > I know that our repository is mirrored at GitHub [1]. > >>>> >> >> >> >>>> > > >>>> >> >> >> >>>> > There is one PR already. I think we missed that. > >>>> >> >> >> >>>> > > >>>> >> >> >> >>>> > I didn't try anything related to this. Just sending > this > >>>> >> >> >> >>>> > to > >>>> >> >> >> >>>> > get > >>>> >> >> >> >>>> > ideas > >>>> >> >> >> >>>> > of > >>>> >> >> >> >>>> > others. > >>>> >> >> >> >>>> > > >>>> >> >> >> >>>> > Thanks! > >>>> >> >> >> >>>> > > >>>> >> >> >> >>>> > Best Regards, > >>>> >> >> >> >>>> > > >>>> >> >> >> >>>> > [1] https://github.com/apache/incubator-stratos > >>>> >> >> >> >>>> > > >>>> >> >> >> >>>> > -- > >>>> >> >> >> >>>> > Isuru Perera > >>>> >> >> >> >>>> > Senior Software Engineer | WSO2, Inc. | > http://wso2.com/ > >>>> >> >> >> >>>> > Lean . Enterprise . Middleware > >>>> >> >> >> >>>> > > >>>> >> >> >> >>>> > about.me/chrishantha > >>>> >> >> >> >>>> > >>>> >> >> >> >>>> > >>>> >> >> >> >>>> > >>>> >> >> >> >>>> -- > >>>> >> >> >> >>>> Check out my professional profile and connect with me on > >>>> >> >> >> >>>> LinkedIn. > >>>> >> >> >> >>>> http://lnkd.in/cw5k69 > >>>> >> >> >> >>> > >>>> >> >> >> >>> > >>>> >> >> >> >>> > >>>> >> >> >> >>> > >>>> >> >> >> >>> -- > >>>> >> >> >> >>> Best Regards, > >>>> >> >> >> >>> Nirmal > >>>> >> >> >> >>> > >>>> >> >> >> >>> Nirmal Fernando. > >>>> >> >> >> >>> PPMC Member & Committer of Apache Stratos, > >>>> >> >> >> >>> Senior Software Engineer, WSO2 Inc. > >>>> >> >> >> >>> > >>>> >> >> >> >>> Blog: http://nirmalfdo.blogspot.com/ > >>>> >> >> >> >> > >>>> >> >> >> >> > >>>> >> >> >> >> > >>>> >> >> >> >> > >>>> >> >> >> >> -- > >>>> >> >> >> >> Best Regards, > >>>> >> >> >> >> Nirmal > >>>> >> >> >> >> > >>>> >> >> >> >> Nirmal Fernando. > >>>> >> >> >> >> PPMC Member & Committer of Apache Stratos, > >>>> >> >> >> >> Senior Software Engineer, WSO2 Inc. > >>>> >> >> >> >> > >>>> >> >> >> >> Blog: http://nirmalfdo.blogspot.com/ > >>>> >> >> >> > > >>>> >> >> >> > > >>>> >> >> >> > > >>>> >> >> >> > > >>>> >> >> >> > -- > >>>> >> >> >> > Best Regards, > >>>> >> >> >> > Nirmal > >>>> >> >> >> > > >>>> >> >> >> > Nirmal Fernando. > >>>> >> >> >> > PPMC Member & Committer of Apache Stratos, > >>>> >> >> >> > Senior Software Engineer, WSO2 Inc. > >>>> >> >> >> > > >>>> >> >> >> > Blog: http://nirmalfdo.blogspot.com/ > >>>> >> >> >> > >>>> >> >> >> > >>>> >> >> >> > >>>> >> >> >> -- > >>>> >> >> >> Check out my professional profile and connect with me on > >>>> >> >> >> LinkedIn. > >>>> >> >> >> http://lnkd.in/cw5k69 > >>>> >> >> > > >>>> >> >> > > >>>> >> >> > > >>>> >> >> > > >>>> >> >> > -- > >>>> >> >> > Best Regards, > >>>> >> >> > Nirmal > >>>> >> >> > > >>>> >> >> > Nirmal Fernando. > >>>> >> >> > PPMC Member & Committer of Apache Stratos, > >>>> >> >> > Senior Software Engineer, WSO2 Inc. > >>>> >> >> > > >>>> >> >> > Blog: http://nirmalfdo.blogspot.com/ > >>>> >> >> > >>>> >> >> > >>>> >> >> > >>>> >> >> -- > >>>> >> >> Check out my professional profile and connect with me on > LinkedIn. > >>>> >> >> http://lnkd.in/cw5k69 > >>>> >> > > >>>> >> > > >>>> >> > > >>>> >> > > >>>> >> > -- > >>>> >> > Best Regards, > >>>> >> > Nirmal > >>>> >> > > >>>> >> > Nirmal Fernando. > >>>> >> > PPMC Member & Committer of Apache Stratos, > >>>> >> > Senior Software Engineer, WSO2 Inc. > >>>> >> > > >>>> >> > Blog: http://nirmalfdo.blogspot.com/ > >>>> >> > >>>> >> > >>>> >> > >>>> >> -- > >>>> >> Check out my professional profile and connect with me on LinkedIn. > >>>> >> http://lnkd.in/cw5k69 > >>>> > > >>>> > > >>>> > > >>>> > > >>>> > -- > >>>> > Best Regards, > >>>> > Nirmal > >>>> > > >>>> > Nirmal Fernando. > >>>> > PPMC Member & Committer of Apache Stratos, > >>>> > Senior Software Engineer, WSO2 Inc. > >>>> > > >>>> > Blog: http://nirmalfdo.blogspot.com/ > >>>> > >>>> > >>>> > >>>> -- > >>>> Check out my professional profile and connect with me on LinkedIn. > >>>> http://lnkd.in/cw5k69 > >>> > >>> > >>> > >>> > >>> -- > >>> Best Regards, > >>> Nirmal > >>> > >>> Nirmal Fernando. > >>> PPMC Member & Committer of Apache Stratos, > >>> Senior Software Engineer, WSO2 Inc. > >>> > >>> Blog: http://nirmalfdo.blogspot.com/ > >> > >> > >> > >> > >> -- > >> Isuru Perera > >> Senior Software Engineer | WSO2, Inc. | http://wso2.com/ > >> Lean . Enterprise . Middleware > >> > >> about.me/chrishantha > > > > > > > > -- > > Check out my professional profile and connect with me on LinkedIn. > > http://lnkd.in/cw5k69 > > > > -- > Check out my professional profile and connect with me on LinkedIn. > http://lnkd.in/cw5k69 > -- Lakmal Warusawithana Software Architect; WSO2 Inc. Mobile : +94714289692 Blog : http://lakmalsview.blogspot.com/
