[
https://issues.apache.org/jira/browse/STRATOS-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14012098#comment-14012098
]
Jeffrey Nguyen commented on STRATOS-657:
----------------------------------------
Thanks Imesh. For record-keeping, I'm listed all the commits between the
two commit Ids you mentioned. Can you confirm all of them are needed for
port map changes?
Since you mentioned the above enhancement is done only in master branch,
when testing with RC3 code, we should always see protocol name as the key
for the port mapping JSON instead of a string representation of a port
number, e.g. "http" instead of "80"? One of my co-workers mentioned he
always saw integer string values before.
In our customer RC3 build, we have 3 additional fixes cherry-picked from
master branch as mentioned in [1] below. The first two have nothing to do
with messaging and involved only a few files. The third fix for the
cinder volume support involves lots of files changed. Do you think the
cinder volume might have some unintended side-effects?
[1] List of fixes cherry picked from master branch and added on top of RC3
code
- Fix for cartridge agent - spawned instance not converged to active state
(STRATOS-643)
commit cbcb71c3507a8113c0bc7428f629795a39137689
STRATOS-643: launched instance cannot convert to active state
- Fix for floating IP allocation issue (STRATOS-646)
commit 535a645561f75d98d6d79acd2506a9651d8b64f9
STRATOS-646: Floating IP allocation fails if we don't pre-allocate
floating Ips
- Cinder volume support
commit a2f393338448e229e64dc5a61cad5cce1ded1ad3
Issue Making volume size not mandatory not mandatory
commit ffa5f1ec81fa2e9137a08577820094ad9de8dde0
Issue Adding feature to create an volume from an snapshot.
commit f19ac322c9e2775b0661ba22095b53c5b24f6e52
Issue feature to attach volumes from a volumeID
[2] List of commits required for changes in port mapping data structure
related changes
commit 3d3fc9d31199e4b108ec034ca4ab809f998c7e3f
Author: Imesh Gunaratne <im...@apache.org>
Date: Fri May 2 17:03:15 2014 +0530
Changed transport.equals(port.getProtocol()) to
transport.startsWith(port.getProtocol()) to let protocols to be defined
with suf
commit 2dbaae431887aee8ebd1349c5366ed386815883d
Author: Imesh Gunaratne <im...@apache.org>
Date: Fri May 2 16:13:23 2014 +0530
Fixed default port issue and used axis2 member http/https port
properties
commit ace6d562d195856cc95b559e7d91379c6331317a
Author: Imesh Gunaratne <im...@apache.org>
Date: Fri May 2 10:48:02 2014 +0530
Updated pom.xml and bin.xml files to fix assembly id being mandatory
after updating maven-assembly-plugin version to 2.2.1
Signed-off-by: Imesh Gunaratne <im...@apache.org>
commit 50536fc8f42e572fac113248fb62ef72d471e9fc
Author: Imesh Gunaratne <im...@apache.org>
Date: Fri May 2 09:09:54 2014 +0530
Removed maven assembly plugin version from stratos parent pom.xml to
be inherited from apache pom.xml
Signed-off-by: Imesh Gunaratne <im...@apache.org>
commit 65b4f4f28887008e46b21a5f4faab792e6a95672
Author: Imesh Gunaratne <im...@wso2.com>
Date: Thu May 1 12:52:05 2014 +0530
Fetched incoming request port from axis2 message context property
TARGET_HOST
commit 10bb2e15a0d98afbaee988be654276b9a2dae21f
Author: Imesh Gunaratne <im...@wso2.com>
Date: Thu May 1 11:30:45 2014 +0530
Updated port map abstraction to expose port map as a collection
commit f7dca7d5fb5aa6312b86028c3ac72c15de7c9fed
Author: Imesh Gunaratne <im...@wso2.com>
Date: Thu May 1 11:18:07 2014 +0530
Updated load balancer configuration test according new port mapping
model
commit e4b15b6f52253b804c5e716fbcf1c1db47111dc2
Author: Imesh Gunaratne <im...@wso2.com>
Date: Thu May 1 10:38:21 2014 +0530
Updated load balancer port mapping logic to find outgoing port
according to the incoming port rather than looking at the transpo
> Topology update events failed to be de-serialized due to incorrect port
> mapping format
> --------------------------------------------------------------------------------------
>
> Key: STRATOS-657
> URL: https://issues.apache.org/jira/browse/STRATOS-657
> Project: Stratos
> Issue Type: Bug
> Components: Cloud Controller, Stratos Manager
> Affects Versions: 4.0.0, 4.0.0 RC1
> Environment: Apache Stratos 4.0.0 RC3, openstack havana
> Reporter: Jeffrey Nguyen
>
> We have a topology listener component that listens to topology update events
> in activemq. We're seeing exceptions as one shown below when events such as
> MemberActivatedEvent or CompleteTopologyEvent
> In the exception stacktrace below,
> "portMap":{"http":{"protocol":"http","value":22,"proxy":8280}},"memberIp":"1.2.3.4"}
> should be something like
> "portMap":{"80":{"protocol":"http","value":22,"proxy":8280}},"memberIp":"1.2.3.4"}
> 2014-05-28 15:43:45 | DEBUG | TopologyEventsListener:63: Received topology
> message of type:
> org.apache.stratos.messaging.event.topology.MemberActivatedEvent,payload={"serviceName":"cisco-sample-vm","clusterId":"sample-vm.sample-v","networkPartitionId":"N1","partitionId":"RegionOne","memberId":"sample-vm.sample-v1e5e272d-1bbe-4a7b-9c4e-92890363abea","portMap":{"http":{"protocol":"http","value":22,"proxy":8280}},"memberIp":"1.2.3.4"}
> Exception in thread "Thread-0" com.google.gson.JsonSyntaxException:
> java.lang.NumberFormatException: For input string: "http"
> at
> com.google.gson.internal.bind.TypeAdapters$7.read(TypeAdapters.java:241)
> at
> com.google.gson.internal.bind.TypeAdapters$7.read(TypeAdapters.java:231)
> at
> com.google.gson.internal.bind.TypeAdapterRuntimeTypeWrapper.read(TypeAdapterRuntimeTypeWrapper.java:40)
> at
> com.google.gson.internal.bind.MapTypeAdapterFactory$Adapter.read(MapTypeAdapterFactory.java:186)
> at
> com.google.gson.internal.bind.MapTypeAdapterFactory$Adapter.read(MapTypeAdapterFactory.java:145)
> at
> com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$1.read(ReflectiveTypeAdapterFactory.java:93)
> at
> com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$Adapter.read(ReflectiveTypeAdapterFactory.java:172)
> at com.google.gson.Gson.fromJson(Gson.java:803)
> at com.google.gson.Gson.fromJson(Gson.java:768)
> at com.google.gson.Gson.fromJson(Gson.java:717)
> at com.google.gson.Gson.fromJson(Gson.java:689)
> at
> org.apache.stratos.messaging.message.JsonMessage.<init>(JsonMessage.java:38)
> at org.apache.stratos.messaging.util.Util.jsonToObject(Util.java:105)
> at
> com.cisco.apache.stratos.topologylistener.TopologyEventsListener.run(TopologyEventsListener.java:100)
> at java.lang.Thread.run(Thread.java:745)
> Caused by: java.lang.NumberFormatException: For input string: "http"
> at
> sun.misc.FloatingDecimal.readJavaFormatString(FloatingDecimal.java:1241)
> at java.lang.Double.parseDouble(Double.java:540)
> at com.google.gson.stream.JsonReader.nextInt(JsonReader.java:1178)
> at
> com.google.gson.internal.bind.TypeAdapters$7.read(TypeAdapters.java:239)
> ... 14 more
--
This message was sent by Atlassian JIRA
(v6.2#6252)
