Hi Daniel, thanks, your pull request looks very good and I directly merged it. When I saw it correctly the labels are currently set in the UI and not persisted to the database, right?
So I think the next step would be to implement the backend to update the labels in the database. The endpoint for the data lake is defined in the class DataLakeResourceV3 [1]. Here we would need a new POST endpoint with the parameters: startDate, endDate, and label to update the database values. My suggestion would be not to reload the data directly after a new label is added, instead update the UI and the backend to ensure a better user experience. Regarding the naming for the label column in the database. We could add a new column to each data stream called ’sp_internal_label’ containing a String value for each datapoint with the label. Alternatively we could add a new table to a database (e.g. couchdb) with just the label information and then merge the information before it is sent to the browser. This would ease the insertion of new labels, but make requesting the data more complex. I would prefer to add a label to each data point. This solution makes the creation of labels a bit more challenging, but should have a better performance on querying the data. How do you think about that? Kind regards, Philipp [1] https://github.com/apache/incubator-streampipes/blob/9e5cafd11f530d5212f973da7b532b0dd102c22d/streampipes-rest/src/main/java/org/apache/streampipes/rest/impl/datalake/DataLakeResourceV3.java <https://github.com/apache/incubator-streampipes/blob/9e5cafd11f530d5212f973da7b532b0dd102c22d/streampipes-rest/src/main/java/org/apache/streampipes/rest/impl/datalake/DataLakeResourceV3.java> On 2020/04/01 21:33:48, Daniel Ebi <e...@fzi.de> wrote: > Hi there,> > > I have extended the time series data labeling tool in such a way that the > labeling mode now remains activated after clicking the 'Labeling'-button - > until it gets deactivated by clicking the button again or by switching to the > plotly-specific 'Pan' or 'Zoom' mode. The activation of the labeling mode is > highlighted by color adjustment of the 'Labeling'-button icon.> > > > > Just now I've already created a pull request on Github (pull request #13).> > > > > Daniel> > > > > -----Ursprüngliche Nachricht-----> > > Von: Philipp Zehnder <ze...@apache.org> > > > Gesendet: Dienstag, 31. März 2020 17:54> > > An: dev@streampipes.apache.org> > > Betreff: Re: AW: Time Series Data Labeling Tool> > > > > Hi Daniel,> > > > > the time labeling tool looks very cool. I checked it out and it directly > worked.> > > > > One question. Currently I have to click on the button (‘label’, on the top > right corner) for each label I want to select. > > > Can we change that behavior. I would expect that a user is entering the > labeling mode, once the button is clicked and exits it again when the button > is clicked again.> > > > > Philipp> > > > > On 2020/03/27 13:31:20, Daniel Ebi <e....@fzi.de> wrote: > > > > Hi there,> > > > > > > > > I just wanted to let you know that I created the pull request for the time > > series labeling tool today (pull request #12).> > > > > > > > > > > > > > > > > During the last days, I have been working on the main components for the > > mentioned time series labeling tool and I already implemented a working > > version.> > > > > > > > > > > > > > > > > Cheers,> > > > > > > > > Daniel> > > > > > > > > > > > > > > > > -----Ursprüngliche Nachricht-----> > > > > > > > > Von: Daniel Ebi > > > > > > > > > Gesendet: Dienstag, 24. März 2020 17:35> > > > > > > > > An: 'dev@streampipes.apache.org' <de...@streampipes.apache.org>> > > > > > > > > Betreff: AW: New Contributer | Time Series Data Labeling Tool> > > > > > > > > > > > > > > > > Hi Philipp, hi Johannes,> > > > > > > > > thanks for your short guidance and the warm welcome. > > > > > > > > > > > > > > > > > @Philipp: It all worked out well.> > > > > > > > > > > > > > > > > @Johannes: I will look into it and check which components I can reused.> > > > > > > > > > > > > > > > > Cheers,> > > > > > > > > Daniel> > > > > > > > > > > > > > > > > ________________> > > > > > > > > On 2020/03/24 16:43:33, Johannes Tex wrote:> > > > > > > > > > > > > > > > > Hi Daniel,> > > > > > > > > > > > > > > > > welcome :)> > > > > > > > > > > > > > > > > As you mentioned, I have started to develop an image labeling tool. > > > > > > > > > I think some of the components can be resused, for example the > > "image-labels" component [1].> > > > > > > > > It is a component for selecting labels received from the backend (at the > > moment it is only mocked). You also can use the num-pad change labels, it's > > for the power users ;) You can have a view and we can discuss it if you > > have comments or questions.> > > > > > > > > > > > > > > > > Johannes> > > > > > > > > > > > > > > > > [1] > > https://github.com/apache/incubator-streampipes/tree/b2e92c667d77e7b7e724112463bb25141881ffd6/ui/src/app/core-ui/image/components/image-labels> > > > > > > > > > > > > > > > > > > ________________> > > > > > > > > On 2020/03/24 16:17:16, Philipp Zehnder wrote:> > > > > > > > > > > > > > > > > Hi Daniel,> > > > > > > > > > > > > > > > > a warm welcome to the mailing list!> > > > > > > > > > > > > > > > > You can start developing on the UI using the cli tool in our installer [1]. > > (Currently in the dev branch) I’d suggest you use the lite version (‘sp > > set-template lite') and run a local StreamPipes instance on your computer > > (‘sp set-template lite').> > > > > > > > > The code for the UI is in [2] in the ui folder. Check out the repository > > and navigate to the folder.> > > > > > > > > Then run ’npm install’ and ’npm start’. (This might take a while) > > Afterwards you can navigate to ‘localhost:8082’ in your browser and you can > > start developing.> > > > > > > > > > > > > > > > > Cheers,> > > > > > > > > Philipp> > > > > > > > > > > > > > > > > [1] https://github.com/apache/incubator-streampipes-installer > > <https://github.com/apache/incubator-streampipes-installer>> > > > > > > > > [2] https://github.com/apache/incubator-streampipes > > <https://github.com/apache/incubator-streampipes>> > > > > > > > > > > > > > > > > _______________________> > > > > > > > > On 2020/03/24 10:54:12, Daniel Ebi <eb...@fzi.de> wrote: > > > > > > > > > > Hey there,> > > > > > > > > > my name is Daniel and I would like to contribute to Apache StreamPipes > > > project. Therefore I recently joined this dev mailing list.> > > > > > > > > > > > > > > > > > > > About me> > > > > > > > > > I study Information Engineering and Management in the Master's program - > > > with focus on Machine Learning and Artificial Intelligence - at Karlsruhe > > > Institute of Technologie (KIT). Additionally, I work as a student > > > assistant at the FZI in Karlsruhe in order to gain some practical > > > experience in research. There I got in contact with StreamPipes and > > > became interested in the project. In the course of my studies I already > > > gathered much experience in the Machine Learning and Data Science > > > domain.> > > > > > > > > > > > > > > > > > > > What are my current ideas for Apache StreamPipes?> > > > > > > > > > Specifically, I would like to develop a labeling feature for Apache > > > StreamPipes that allows users to label time series data easily and > > > intuitively (like the image labeling tool of Johannes [1]). My idea is to > > > extend the line chart of the data explorer in such a way that one or more > > > labels can be added by simply marking the data points of interest. The > > > visualization of the data is thereby used as a basis for the labeling, > > > and the labelled data can be afterwards illustrated with colored > > > overlays, too. The long-term goal is to ensure that the data labelled in > > > this way can be used as a starting point for machine learning > > > procedures.> > > > > > > > > > > > > > > > > > > > I will be very happy to hear about your suggestions about my plans. > > > Thanks in advance.> > > > > > > > > > > > > > > > > > > > Best regards,> > > > > > > > > > Daniel Ebi> > > > > > > > > > > > > > > > > > > > ________________________________> > > > > > > > > > [1] > > > > > > > > > > https://issues.apache.org/jira/projects/STREAMPIPES/issues/STREAMPIPES> > > > > > > > > > -78?filter=allopenissues> > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >
