Hi Philipp,

I removed the AngularJS router and replaced it with the integrated Angular 
router. So all routes are now managed in the app-routing.module.ts file in the 
application root.
Similar to the old routing, this file is auto-generated by the prebuild script, 
so in case we're changing anything here or in the app.module, the .mst files in 
the prebuild folder need to be modified.

In case you want to add more routes, you either add them manually to the 
app-routing.module.mst file or use the existing modules.yml file, which will 
add the routes automatically. 

The guards are now used to check for route access, e.g., user authentification 
and is something we can extend in the next release once we implement more 
sophisticated authorization concepts.

Does this answer your question?

Dominik

On 2020/08/24 11:25:22, Philipp Zehnder <[email protected]> wrote: 
> Hi Dominik,
> 
> awesome job! It will now be much easier to work in the UI nowΩ.
> 
> When I was looking over the changes I saw the new directory ‘guards’. It 
> looks like we need this for the new routing and authentication.
> Can you briefly explain how the routing works now and what we should consider 
> when developing?
> 
> Philipp 
> 
> > On 19. Aug 2020, at 11:31, Dominik Riemer <[email protected]> wrote:
> > 
> > Hi,
> > 
> > I've just merged the migrated UI into dev and will also close all related 
> > JIRA issues - if you find any bugs or things we need to improve, feel free 
> > to create a new ticket or reply to this mail!
> > 
> > Dominik
> > 
> > On 2020/08/16 11:59:42, "Dominik Riemer" <[email protected]> wrote: 
> >> Hi all,
> >> 
> >> 
> >> 
> >> I've completed the migration of the UI core modules from AngularJS to
> >> Angular and have a complete AngularJS-free version running in branch
> >> STREAMPIPES-193 [1].
> >> 
> >> What do you think? Should I merge it into dev so that it will be part of 
> >> the
> >> next release?
> >> 
> >> 
> >> 
> >> Dominik
> >> 
> >> 
> >> 
> >> [1]  <https://github.com/apache/incubator-streampipes/tree/STREAMPIPES-193>
> >> https://github.com/apache/incubator-streampipes/tree/STREAMPIPES-193
> >> 
> >> 
> >> 
> >> 
> >> 
> >> 
> >> 
> >> 
> >> 
> >> 
> 
> 

Reply via email to