Hi Dominik, this is a very cool feature! I tried it out in connect and also in the csv meta data enricher and everything worked fine.
I have a little suggestion for improvement, if you haven't already seen it. Currently when I upload a new file this is not selected as default. A user has to go back to the overview and select the file manually. This can be a bit confusing for users and I think it should be easy to fix. Philipp On 2020/09/16 08:07:45, Branislav Jovicic <b...@nissatech.com> wrote: > Perfect. I believe this will improve overall user experience.> > Thank you.> > > Kindest regards,> > Branislav> > ________________________________> > From: Dominik Riemer <ri...@apache.org>> > Sent: Wednesday, September 16, 2020 9:59 AM> > To: dev@streampipes.apache.org <de...@streampipes.apache.org>> > Subject: Re: File extensions> > > Hi Branislav,> > > yes, both is possible, you can either use one of some predefined filetypes > for convenience or simply define a filetype by providing the extension as a > string value.> > > Dominik> > > On 2020/09/16 07:28:33, Branislav Jovicic <br...@nissatech.com> wrote:> > > Hi, Dominik,> > >> > > That is great to hear.> > >> > > What file types are going to be supported? Will user be able to specify > > custom file type, if said file type is not available?> > >> > > Kindest regards,> > > Branislav> > > ________________________________> > > From: Dominik Riemer <ri...@apache.org>> > > Sent: Tuesday, September 15, 2020 9:04 PM> > > To: dev@streampipes.apache.org <de...@streampipes.apache.org>> > > Subject: Re: File extensions> > >> > > Hi Branislav,> > >> > > I have some good news, since we had a bug in the file static property due > > to some major changes in our UI layer, I worked on harmonizing the file > > download for adapters and pipeline elements.> > >> > > So the feature to restrict file static properties to extensions and a > > simple user interface for uploading and deleting files will be available in > > the upcoming version 0.67.0> > >> > > E.g., you can do something like .requiredFile(Labels.withId(CSV_FILE_KEY), > > Filetypes.CSV) [1]> > >> > > Dominik> > >> > > [1] > > https://github.com/apache/incubator-streampipes-extensions/blob/dev/streampipes-processors-transformation-jvm/src/main/java/org/apache/streampipes/processors/transformation/jvm/processor/csvmetadata/CsvMetadataEnrichmentController.java> > > > >> > > On 2020/08/31 07:30:20, Branislav Jovicic <br...@nissatech.com> wrote:> > > > Hi,> > > >> > > > Since there will be an increased use of files in the future, I think it > > > would be good to have this centralized management implemented.> > > > I also like the features you mentioned, since I find them to be quite > > > useful.> > > >> > > > Be assured that I would contact you in case I come up with some > > > additional useful features.> > > >> > > > Kindest regards,> > > > Branislav> > > > ________________________________> > > > From: Dominik Riemer <ri...@apache.org>> > > > Sent: Thursday, August 27, 2020 11:29 PM> > > > To: dev@streampipes.apache.org <de...@streampipes.apache.org>> > > > Subject: Re: File extensions> > > >> > > > Hi Branislav,> > > >> > > > I thought of a central place to view and manage file uploads. Currently, > > > we mainly use files for some StreamPipes Connect adapters and pipeline > > > elements, but there will be probably more components requiring external > > > files in the future, e.g., ML models or annotations from the image > > > labeling tool some community members are currently working on.> > > > So it would be nice to have an integrated UI module to:> > > > * upload and download and delete files> > > > * manage files, e.g., categorizing and tagging files> > > > * restricting file access for specific adapters/pipeline elements/users> > > >> > > > What do you think, is something missing? These are just some first > > > thoughts, any additional ideas are welcome!> > > >> > > > Dominik> > > >> > > > On 2020/08/26 10:33:16, Branislav Jovicic <br...@nissatech.com> wrote:> > > > > Hi, Dominik,> > > > >> > > > > You are welcome. I am glad I could contribute in this way.> > > > >> > > > > The idea of centralizing management of uploaded files seems good and I > > > > think it could improve overall user experience. What would be the core > > > > features of this "File Management Center"?> > > > >> > > > > Maybe we can come up with some ideas together. I would love to hear > > > > more from you on this.> > > > >> > > > > Branislav> > > > > ________________________________> > > > > From: Dominik Riemer <ri...@apache.org>> > > > > Sent: Wednesday, August 26, 2020 11:47 AM> > > > > To: dev@streampipes.apache.org <de...@streampipes.apache.org>> > > > > Subject: Re: File extensions> > > > >> > > > > Hi Branislav,> > > > >> > > > > thanks for this feature suggestion!> > > > > This is a very useful feature so I directly added an issue [1] to track > > > > this. I guess we can do this for the release after the next release, > > > > which is currently in final preparations.> > > > >> > > > > We also thought about adding a "file management center" in the UI to > > > > centrally manage all uploaded files (e.g., by pipeline elements and > > > > Connect adapters/data sets). Do you think such a feature would be > > > > useful?> > > > >> > > > > Dominik> > > > >> > > > > [1] https://issues.apache.org/jira/browse/STREAMPIPES-209> > > > >> > > > > On 2020/08/26 08:36:26, Branislav Jovicic <br...@nissatech.com> wrote:> > > > > > Greetings,> > > > > >> > > > > > I have a minor suggestion regarding requiredFile configuration > > > > > option. I noticed there is no option to specify file extension.> > > > > > This is not very important feature, especially in this phase of > > > > > development, and I do not know whether you were planning on adding > > > > > it, but I believe it will subtly improve user experience and make > > > > > things less error-prone and safer to work with.> > > > > >> > > > > > Kindest regards,> > > > > > Branislav> > > > > >> > > > >> > > >> > >> >
