Ok - I’ll start another discussion in a separate thread. Regarding the Dockerfile: yepp - this works! you simply have to adjust the build context, e.g. the following command executed from the root dir of the project with a Dockerfile in docker/Dockerfile.backend:
docker build -t apachestreampipes/backend:text -f docker/Dockerfile.backend streampipes-backend/ Patrick > Am 06.11.2020 um 15:30 schrieb Philipp Zehnder <[email protected]>: > > Yes we can discuss this in a separate thread. > > I was wondering if this change would also effect the location of the ui > folder. Currently this folder is within the backend project, but I think in > the new structure the ui could be a top level folder. > > Regarding the docker files. I am not sure if we can move them, because each > Dockerfile needs all the build artifacts. > Would this mapping also work, when the docker files are in a different > location? > > Philipp > > >> On 6. Nov 2020, at 15:16, Patrick Wiener <[email protected]> wrote: >> >> This would definitely have a major effect on it. I like the idea of merging >> extensions + core together into one holistic streampipes project. >> From the CI point of view however, this also increase build times but I >> argue it’s ok to reduce the setup, development complexity in conjunction >> with easier releasing. >> >> Should we discuss this in a separate thread because the adaptations here >> would only be a subset of things to do when merging the two repos? >> >> Patrick >> >>> Am 06.11.2020 um 15:07 schrieb Philipp Zehnder <[email protected]>: >>> >>> Hi Patrick, >>> >>> during the release we started the discussion if we should merge the >>> extensions project with the backend project in GitHub to simplify our >>> project structure. >>> I was wondering if we should do this first because it will also have a big >>> effect on the CI job, right? >>> >>> Whats your opinion on that? >>> >>> Philipp >>> >>>> On 6. Nov 2020, at 14:55, Patrick Wiener <[email protected]> wrote: >>>> >>>> Hi guys, >>>> >>>> i noticed the current CI workflow file using Github Actions is pretty >>>> confusing when looking at it. >>>> >>>> - I’d suggest to have a more clean structure and using a separate shell >>>> script that performs the actual build, e.g., tools/ci/docker_build_push.sh >>>> - We could move the Dockerfiles (especially in the core repo) to a central >>>> location within the repo, e.g. docker/ >>>> - We could rename ui/ -> streampipes-ui/ >>>> >>>> What do you think? Are there any other suggestions that might help improve >>>> the CI + overall project structure? >>>> >>>> Patrick >>>> >>>> >>> >> >
