Sorry for the late reply. The improved wrapper looks really clean, intuitive and easy to work with. With this, it'll be easier to expose any builtin siddhi extensions. Great work Dominik.
However, I think we shouldn't expose all the Siddhi extensions unless they are most commonly used or required by the community. Because otherwise, it'll clutter the list of SP processors. Grainier Perera. On Tue, 27 Oct 2020 at 02:41, Dominik Riemer <[email protected]> wrote: > Hi all, > > Branislav has recently asked for list support in the Siddhi wrapper (e.g., > filter a list for contained items). > I took the opportunity to extend and improve the Siddhi wrapper in some > ways: > > - Support for lists (see example processors at [1, 2]) > - Possibility to create a new Siddhi processor from a single class (no > controller and parameter class needed anymore, there is also a prototype of > the same structure available for the standalone wrapper > (StreamPipesDataProcessor) > - I added a simple object model to create Siddhi EPL statements instead of > the previous string-based approach. This should the creation of Siddhi > processors less error-prone. The object model is still rather incomplete > and > undocumented, but it should be easy to extend in the future - the code is > at > [3] > - Improved code structure of the whole wrapper to make it easier to extend > in the future > > What do you think? Any feedback is welcome! > > Also @Grainier, as you are the Siddhi expert, in case you have any ideas > for > improvements, let me know! > > Dominik > > [1] > > https://github.com/apache/incubator-streampipes-extensions/blob/dev/streampi > > pes-processors-filters-siddhi/src/main/java/org/apache/streampipes/processor > s/siddhi/listfilter/ListFilter.java > <https://github.com/apache/incubator-streampipes-extensions/blob/dev/streampipes-processors-filters-siddhi/src/main/java/org/apache/streampipes/processors/siddhi/listfilter/ListFilter.java> > [2] > > https://github.com/apache/incubator-streampipes-extensions/blob/dev/streampi > > pes-processors-filters-siddhi/src/main/java/org/apache/streampipes/processor > s/siddhi/listcollector/ListCollector.java > <https://github.com/apache/incubator-streampipes-extensions/blob/dev/streampipes-processors-filters-siddhi/src/main/java/org/apache/streampipes/processors/siddhi/listcollector/ListCollector.java> > [3] > > https://github.com/apache/incubator-streampipes/tree/dev/streampipes-wrapper > -siddhi/src/main/java/org/apache/streampipes/wrapper/siddhi/query > <https://github.com/apache/incubator-streampipes/tree/dev/streampipes-wrapper-siddhi/src/main/java/org/apache/streampipes/wrapper/siddhi/query> > > > > >
