Hi Samarth, welcome to our mailing list and thank you for your contribution! I just had a look at your PR. Just to get it right, it is your idea to check for each incoming event if there are already one or more events in the StreamBuffer that can be merged with the incoming one? And if there are multiple matches, multiple events are emitted? I'm not quite sure, whether we should provide the buffering per default or only by choice because leads to big confusion if it's not expected. At least, we should limit buffering to when a new event arrives for the buffered stream, so that un-synchronized streams can still be merged.
@all, how would you handle the stream buffering? In the declare model you have to specify the two required inputStreams. For example this could look like: .requiredStream(StreamRequirementsBuilder .create() .requiredProperty(EpRequirements.anyProperty()) .build()) .requiredStream(StreamRequirementsBuilder .create() .requiredProperty(EpRequirements.anyProperty()) .build()) Also, the EventSchema does not yet override the equals method and therefore the comparison does not work properly. If you want, you can try to implement that as well. Apart from this general things, your provided code looks very good. There are some minor things that we can address once we have agreed on this point, if that's okay with you? Best Tim On März 29 2021, at 2:57 pm, Samarth Sah <[email protected]> wrote: > Hi All, > > I am new to Streampipes. > I have raised the pull request: > https://github.com/apache/incubator-streampipes-extensions/pull/39, > regarding the issue https://issues.apache.org/jira/browse/STREAMPIPES-323. > > Please let me know if I am in the right direction. > Thank you, > Samarth > > > > On Mon, Mar 29, 2021 at 6:04 PM GitBox <[email protected]> wrote: > > > > Samarth08 opened a new pull request #39: > > URL: https://github.com/apache/incubator-streampipes-extensions/pull/39 > > > > > > Fixes: https://issues.apache.org/jira/browse/STREAMPIPES-323 > > > > > > > > -- > > This is an automated message from the Apache Git Service. > > To respond to the message, please log on to GitHub and use the > > URL above to go to the specific comment. > > > > For queries about this service, please contact Infrastructure at: > > [email protected] > > > > > > >
