tenthe commented on code in PR #104:
URL:
https://github.com/apache/incubator-streampipes/pull/104#discussion_r948355451
##########
streampipes-extensions/streampipes-connect-adapters-iiot/src/main/java/org/apache/streampipes/connect/iiot/protocol/stream/FileStreamProtocol.java:
##########
@@ -211,11 +211,12 @@ public GuessSchema getGuessSchema() throws ParseException
{
List<byte[]> dataByte = parser.parseNEvents(dataInputStream, 2);
- EventSchema eventSchema = parser.getEventSchema(dataByte);
-
- GuessSchema result = SchemaGuesser.guessSchma(eventSchema);
-
- return result;
+ if (parser.supportsPreview()) {
Review Comment:
I was wondering if it makes sense to deprecate it now, as a reminder to
implement it for all parsers and remove it in the future releases?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
