Hi, I added the checkstyle.xml as mentioned [1]. Is there anythink else I have to do to start the check?
If I do "check all modified files in the checkStyle toolbar, and set Rules to <active configurations> I get "No Rules file has been configured". Greetings Florian [1] https://cwiki.apache.org/confluence/display/STREAMPIPES/Code+Style+-+Java Am Mittwoch, dem 26.10.2022 um 09:52 +0000 schrieb Philipp Zehnder: > Hi Tim,<br> > > thanks for providing the links.<br> > I added a short description for Java in [1]. Maybe we can use this as the > central place for best practices. You are welcome to change and customize > anything.<br> > > I will also add a similar description for Typescript & Angular.<br> > > > [1] > [https://cwiki.apache.org/confluence/display/STREAMPIPES/Code+Style+-+Java](https://cwiki.apache.org/confluence/display/STREAMPIPES/Code+Style+-+Java)<br> > > …………………………………………………<br> > Philipp Zehnder<br> > > Bytefabrik.AI GmbH<br> > Haid-und-Neu-Str. 10–14<br> > 76131 Karlsruhe<br> > Tel.: +49 721 9654-805<br> > > [[email protected]](mailto:[email protected])<br> > [www.bytefabrik.ai](http://www.bytefabrik.ai) > <[https://www.bytefabrik.ai/](https://www.bytefabrik.ai/)> | > [www.twitter.com/bytefabrik](http://www.twitter.com/bytefabrik)<[https://www.bytefabrik.ai/](https://www.bytefabrik.ai/)><br> > > …………………………………………………<br> > Bytefabrik.AI GmbH<br> > Sitz der Gesellschaft: Karlsruhe<br> > Registergericht: Amtsgericht Mannheim, HRB 741226<br> > Geschäftsführer: Dr.-Ing. Dominik Riemer, Dr.-Ing. Philipp Zehnder<br> > …………………………………………………<br> > > > Von: Tim <[[email protected]](mailto:[email protected])><br> > Datum: Dienstag, 25. Oktober 2022 um 21:47<br> > An: [[email protected]](mailto:[email protected]) > <[[email protected]](mailto:[email protected])><br> > Cc: Philipp Zehnder > <[[email protected]](mailto:[email protected])><br> > Betreff: Re: AW: [DISCUSS] Automatic Typescript model generation<br> > Hi,<br> > > yes that would be benefial.<br> > I've notices that we already have confluence pages for that: [1] [2]<br> > it's just up to us to fill them with live ;)<br> > > Let's see whether we can use these tools in a pre-commit hook, but that<br> > shouldn't be an issue since any executable can be defined as git hook.<br> > Usually, you add a pre-commit hook file to the repository.<br> > This file then needs to be configured by each developer as pre-commit<br> > hook but this really simple and can be done with one git command.<br> > When describing it properly in the development guide and/or README, this<br> > shouldn't be a high bar for any developer.<br> > > I would be happy to move this topic forward with you.<br> > > Best<br> > Tim<br> > > [1]<br> > [https://cwiki.apache.org/confluence/display/STREAMPIPES/Code+Style+-+Java](https://cwiki.apache.org/confluence/display/STREAMPIPES/Code+Style+-+Java)<br> > [2]<br> > [https://cwiki.apache.org/confluence/display/STREAMPIPES/Code+Style+-+Typescript](https://cwiki.apache.org/confluence/display/STREAMPIPES/Code+Style+-+Typescript)<br> > > Am 24.10.2022 22:21 schrieb Philipp Zehnder:<br> > > Hi Tim,<br> > > > > I really like the idea.<br> > > For this we need a uniform style guide, right?<br> > > For the UI we recently switched to ESLint with Prettier as a formatter<br> > > and for Java we use checkstyle. Are those configurations then used by<br> > > the pre-commit hook?<br> > > And what kind of formatting can be done with it?<br> > > > > Where do we need to configure the pre-commit hooks, is that something<br> > > each developer needs to configure, or can we configure it in the<br> > > repository?<br> > > > > Cheers,<br> > > Philipp<br> > > > > > > Von: Tim <[[email protected]](mailto:[email protected])><br> > > Datum: Sonntag, 23. Oktober 2022 um 13:48<br> > > An: [[email protected]](mailto:[email protected]) > > <[[email protected]](mailto:[email protected])><br> > > Betreff: Re: [DISCUSS] Automatic Typescript model generation<br> > > Hi Philipp,<br> > > > > I don't know if this can be solved with the maven plugin used for the<br> > > TypeScript generation.<br> > > An alternative idea of mine would be to use a git-hook for this.<br> > > We could create a git-hook for StreamPipes that checks each committed<br> > > file for the presence of the Apache header and adds it if it is<br> > > missing.<br> > > Pre-commit hooks could also be used for style checks and so on. I'm<br> > > already planning to have a discussion about that approach in general on<br> > > our mailing list, but apparently you have been faster ;) So this could<br> > > be a good first use case for it.<br> > > > > What do you think about this idea?<br> > > > > Best<br> > > Tim<br> > > > > Am 19.10.2022 22:39 schrieb Philipp Zehnder:<br>> > > > Hi all,<br> > > > > > > the TypeScript model for our UI is automatically generated from the<br> > > > Java classes as described in [1].<br> > > > So far this had to be done manually. I added a small script to<br> > > > automate the process [2].<br> > > > > > > This already eases to update process, however the license headers<br> > > > still must be inserted manually.<br> > > > Does anyone have an idea how we could automate this step as well?<br> > > > > > > Here is the link to the corresponding issue [3].<br> > > > > > > Cheers,<br> > > > Philipp<br> > > > > > > [1]<br> > > > [https://cwiki.apache.org/confluence/display/STREAMPIPES/Core-UI+Serialization](https://cwiki.apache.org/confluence/display/STREAMPIPES/Core-UI+Serialization)<br> > > > [2]<br> > > > [https://github.com/apache/incubator-streampipes/blob/dev/create-client-model.sh](https://github.com/apache/incubator-streampipes/blob/dev/create-client-model.sh)<br> > > > [3]<br> > > > [https://issues.apache.org/jira/projects/STREAMPIPES/issues/STREAMPIPES-600](https://issues.apache.org/jira/projects/STREAMPIPES/issues/STREAMPIPES-600)<br>
