RobertIndie commented on PR #128: URL: https://github.com/apache/incubator-streampipes/pull/128#issuecomment-1295803058
Hi @tenthe . Thanks for your testing. > I ran it without the env variable `TEST_MODE` starting a new docker service with Pulsar. Do you have any ideas what the problem might be? I find that there is a race condition issue in the PulsarProtocol. When the `PulsarProtocol.run` returns, the pulsar consumer may not be set up completely. We need to wait for the subscribe operation to complete before `PulsarProtocol.run` returns. I think the best way for it is to do some refactor for the PulsarProtocol by using the CompletableFuture. I will do it in another PR. This PR only lets the consumer subscribe to the earliest position to avoid this problem. This is just a temporary solution because it changes the default configuration. Also, I will submit a new PR to make the subscription position configurable. > Therefore, we can use the builder class `SpecificDataStreamAdapterBuilder`. Great! Thanks for your information and your help. Do you want to submit the patch to this PR or create a new PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
