bossenti commented on code in PR #143:
URL: https://github.com/apache/streampipes/pull/143#discussion_r1026765091
##########
streampipes-client-python/setup.py:
##########
@@ -43,7 +43,7 @@
"interrogate>=1.5.0",
"isort>=5.10.1",
"mypy>=0.990",
- "pandas-stubs>=1.5.1.221024",
+ "pandas-stubs>=1.2.0.62",
Review Comment:
@kulbachcedric Any specific reason? (just out of curiosity)
##########
streampipes-client-python/docs/getting-started/installation.md:
##########
@@ -0,0 +1,39 @@
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one or more
+ ~ contributor license agreements. See the NOTICE file distributed with
+ ~ this work for additional information regarding copyright ownership.
+ ~ The ASF licenses this file to You under the Apache License, Version 2.0
+ ~ (the "License"); you may not use this file except in compliance with
+ ~ the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing, software
+ ~ distributed under the License is distributed on an "AS IS" BASIS,
+ ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ ~ See the License for the specific language governing permissions and
+ ~ limitations under the License.
+ ~
+-->
+
+# 📚 Installation
+
+The StreamPipes Python Client is meant to work with Python 3.8 and above.
Installation can be done via `pip`:
+You can install the latest development version from GitHub, as so:
+
+```bash
+pip install <NEEDS TO BE CLARIFIED>
+```
+
+---
+# 👨💻 Contributing
Review Comment:
@kulbachcedric We could additionally link to our DEVELOPMENT.md here. What
do you think?
##########
streampipes-client-python/docs/getting-started/installation.md:
##########
@@ -0,0 +1,39 @@
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one or more
+ ~ contributor license agreements. See the NOTICE file distributed with
+ ~ this work for additional information regarding copyright ownership.
+ ~ The ASF licenses this file to You under the Apache License, Version 2.0
+ ~ (the "License"); you may not use this file except in compliance with
+ ~ the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing, software
+ ~ distributed under the License is distributed on an "AS IS" BASIS,
+ ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ ~ See the License for the specific language governing permissions and
+ ~ limitations under the License.
+ ~
+-->
+
+# 📚 Installation
+
+The StreamPipes Python Client is meant to work with Python 3.8 and above.
Installation can be done via `pip`:
+You can install the latest development version from GitHub, as so:
+
+```bash
+pip install <NEEDS TO BE CLARIFIED>
+```
+
+---
+# 👨💻 Contributing
+*Before opening a pull request*, review the [Get
Involved](https://streampipes.apache.org/getinvolved.html) page.
+It lists information that is required for contributing to StreamPipes.
+
+When you contribute code, you affirm that the contribution is your original
work and that you
Review Comment:
@dominikriemer is the wording here appropriate?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
