bossenti commented on code in PR #152:
URL: https://github.com/apache/streampipes/pull/152#discussion_r1031764309
##########
streampipes-client-python/streampipes_client/client/client.py:
##########
@@ -102,6 +102,7 @@ def __init__(
# provide all available endpoints here
# name of the endpoint needs to be consistent with the Java client
self.dataLakeMeasureApi = DataLakeMeasureEndpoint(parent_client=self)
+ self.dataStreamApi = SpDataStreamEndpoint(parent_client=self)
Review Comment:
@SvenO3 would you mind just calling the class `DataStreamEndpoint`? (same
applies for `SpDataStream`)
I'm more in favor of class names without this prefix, since we would then
need to add it to almost every class.
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
