GitHub user tenthe added a comment to the discussion: Do we want tom improve our branch protection?
Hi @bossenti, thanks for starting this discussion. I really like rules above, but I am not sure if we should enforce them or rather set them as a default behaviour. There may be situations where it is better to bypass the rules to reduce the overhead. - `del_branch_on_merge`: `true` (+1) - `enable_merge_buttons.squash` - I would like to have this as a default, but I would not completely disable the other options - `required_status_checks.strict`: `true` (+1) - `required_status_checks.contexts`: - The checks should always run, but I had situations before, where it was easier to merge the PR (even with failing checks). In such situations those problems were already fixed in another PR that couldn't directly be merged. - `required_pull_request_reviews.dismiss_stale_reviews` - I would set this to false. As you stated we can activate it when the project is bigger - `required_pull_request_reviews.required_approving_review_count`: `1` - I also like this rule, but sometimes there are situations where a PR has to be merged directly. But this should happen only rarely. - `required_linear_history` : `true` - Here I am not quite sure what the consequences will be GitHub link: https://github.com/apache/streampipes/discussions/882#discussioncomment-4502752 ---- This is an automatically sent email for [email protected]. To unsubscribe, please send an email to: [email protected]
