dominikriemer commented on PR #1169: URL: https://github.com/apache/streampipes/pull/1169#issuecomment-1405653100
To add consul integration tests, I had to refactor handling of environment variables so that these can be mocked. Currently, we use the `Envs` enum to access env variables. The new version defines an `Environment` which provides variables and needs to be injected into the classes where env variable access is needed. Do you have feedback on this approach? I added this only for some variables required for service discovery and would extend the `Environment` class for all other variables if we decide that's a good approach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
