bossenti commented on code in PR #1174:
URL: https://github.com/apache/streampipes/pull/1174#discussion_r1091070364
##########
docker-compose.yml:
##########
@@ -138,13 +141,20 @@ services:
spnet:
influxdb:
- image: fogsyio/influxdb:1.7
+ image: influxdb:2.6
environment:
- INFLUXDB_DATA_ENGINE=tsm1
- INFLUXDB_REPORTING_DISABLED=false
- INFLUXDB_ADMIN_ENABLED=true
+ - DOCKER_INFLUXDB_INIT_USERNAME=admin
+ - DOCKER_INFLUXDB_INIT_PASSWORD=sp-admin
+ - DOCKER_INFLUXDB_INIT_ADMIN_TOKEN=sp-admin
+ - DOCKER_INFLUXDB_INIT_ORG=sp
+ - DOCKER_INFLUXDB_INIT_BUCKET=sp
+ - DOCKER_INFLUXDB_INIT_MODE=setup
volumes:
- influxdb:/var/lib/influxdb
Review Comment:
Is the old one still required?
Is it used to ensure backwards compatibility?
##########
installer/cli/deploy/standalone/couchdb/docker-compose.yml:
##########
@@ -16,9 +16,12 @@
version: "3.4"
services:
couchdb:
- image: couchdb:2.3.1
+ image: couchdb:3.3.1
Review Comment:
please include this in the PR's description as well
##########
docker-compose.yml:
##########
@@ -138,13 +141,20 @@ services:
spnet:
influxdb:
- image: fogsyio/influxdb:1.7
+ image: influxdb:2.6
environment:
- INFLUXDB_DATA_ENGINE=tsm1
- INFLUXDB_REPORTING_DISABLED=false
- INFLUXDB_ADMIN_ENABLED=true
+ - DOCKER_INFLUXDB_INIT_USERNAME=admin
Review Comment:
Do we want to align the naming style here with the envs of couchdb?
##########
installer/cli/.env:
##########
@@ -35,3 +35,8 @@ COMPOSE_PROJECT_NAME=streampipes
#
# default: activemq
#SP_MQTT_HOST=mosquitto
+
+
+# For database migration in v0.91.0 - set init mode to 'upgrade' to migrate an
existing installation
+SP_INFLUX_INIT_MODE=setup
+#SP_INFLUX_INIT_MODE=upgrade
Review Comment:
We should provide an upgrade guide somewhere and also shortly describe this
change in the PR's description (for the release notes)
##########
streampipes-commons/src/main/java/org/apache/streampipes/commons/constants/Envs.java:
##########
@@ -23,9 +23,9 @@ public enum Envs {
SP_PORT("SP_PORT", null),
@Deprecated(since = "0.90.0", forRemoval = true)
- SP_CONSUL_LOCATION("CONSUL_LOCATION", "consul"),
+ SP_CONSUL_LOCATION("CONSUL_LOCATION", "consul", "localhost"),
Review Comment:
Is the deprecation here still valid?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
