bossenti commented on code in PR #1268:
URL: https://github.com/apache/streampipes/pull/1268#discussion_r1105418934
##########
streampipes-extensions/streampipes-processors-geo-jvm/src/main/java/org/apache/streampipes/processors/geo/jvm/jts/processor/latlngtojtspoint/LatLngToJtsPointProcessor.java:
##########
@@ -101,7 +101,11 @@ public void onEvent(Event event, SpOutputCollector
collector) throws SpRuntimeEx
Point geom = SpGeometryBuilder.createSPGeom(lng, lat, epsg);
if (!geom.isEmpty()) {
- event.addField(WKT_RUNTIME, geom.toString());
+ // if activated the stream fails at all
+ //event.removeFieldBySelector(latitudeMapper);
+ //event.removeFieldBySelector(longitudeMapper);
Review Comment:
Frankly speaking, I don't think it's a good idea to commit commented code
for several reasons.
Alternatively, if you want to have a reference for your discussion you could
create a gist, simply paste the code snippet into the discussion, or create a
dedicate branch for it.
But I don't want to get too hung up on two lines of code here right now ✌🏼
So if you want to do it that way, feel free 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
