Kshitiz-Mhto commented on code in PR #1438:
URL: https://github.com/apache/streampipes/pull/1438#discussion_r1160650431
##########
streampipes-extensions/streampipes-sinks-brokers-jvm/pom.xml:
##########
@@ -86,7 +86,6 @@
<dependency>
<groupId>io.nats</groupId>
<artifactId>jnats</artifactId>
- <version>${nats.version}</version>
Review Comment:
when i run osv-scanner for scanning our repo initially in my local machine,
these are the errors it was throwing:
```
Failed to resolve version of io.nats:jnats: property "nats.version" could
not be foundScanned
/home/ibergx00/Documents/oss/streampipes/streampipes-extensions/streampipes-sinks-brokers-jvm/pom.xml
file and found 18 packages
Failed to resolve version of com.google.inject:guice: property
"guice.version" could not be foundScanned
/home/ibergx00/Documents/oss/streampipes/streampipes-maven-plugin/pom.xml file
and found 18 packages
Failed to resolve version of org.apache.flink:flink-connector-kafka_2.11:
property "flink.version" could not be found
Failed to resolve version of org.apache.flink:flink-java: property
"flink.version" could not be found
Failed to resolve version of org.apache.flink:flink-streaming-java_2.11:
property "flink.version" could not be found
Failed to resolve version of org.apache.flink:flink-clients_2.11: property
"flink.version" could not be found Scanned
/home/ibergx00/Documents/oss/streampipes/streampipes-wrapper-flink/pom.xml file
and found 9 packages
```
after i made those changes in `pom.xml`, error get resolved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
