So I updated the Settings in PLC4X and enabled discussions (sorry for having the first messages sent here ;-) ). Seems to be working nicely.
Chris Von: Philipp Zehnder <[email protected]> Datum: Dienstag, 16. Mai 2023 um 13:25 An: [email protected] <[email protected]> Betreff: AW: My first PR merged for the GitHub tooling ... allowing to customize GitHub Discussion emails Hi Chris, that's really good news. Thanks for the info. Cheers, Philipp Von: Dominik Riemer <[email protected]> Datum: Montag, 15. Mai 2023 um 17:09 An: [email protected] <[email protected]> Betreff: Re: My first PR merged for the GitHub tooling ... allowing to customize GitHub Discussion emails Thank you Chris! That’s absolutely great and I guess we will add this to the yaml file. Cheers Dominik ________________________________ Von: Christofer Dutz <[email protected]> Gesendet: Monday, May 15, 2023 4:37:13 PM An: [email protected] <[email protected]> Betreff: AW: My first PR merged for the GitHub tooling ... allowing to customize GitHub Discussion emails Hi all, I just learned in the plc4x project, that we need the “repository” in the title … so here’s what we have: https://github.com/apache/plc4x/blob/develop/.asf.yaml#L62 # Attempt to make the auto-generated github emails more easily readable in email clients. custom_subjects: new_pr: "[PR] {title} ({repository})" close_pr: "Re: [PR] {title} ({repository})" comment_pr: "Re: [PR] {title} ({repository})" diffcomment: "Re: [PR] {title} ({repository})" merge_pr: "Re: [PR] {title} ({repository})" new_issue: "[I] {title} ({repository})" comment_issue: "Re: [I] {title} ({repository})" close_issue: "Re: [I] {title} ({repository})" catchall: "[GH] {title} ({repository})" new_discussion: "[D] {title} ({repository})" edit_discussion: "Re: [D] {title} ({repository})" close_discussion: "Re: [D] {title} ({repository})" close_discussion_with_comment: "Re: [D] {title} ({repository})" reopen_discussion: "Re: [D] {title} ({repository})" new_comment_discussion: "Re: [D] {title} ({repository})" edit_comment_discussion: "Re: [D] {title} ({repository})" delete_comment_discussion: "Re: [D] {title} ({repository})" Chris Von: Christofer Dutz <[email protected]> Datum: Montag, 15. Mai 2023 um 16:24 An: [email protected] <[email protected]> Betreff: My first PR merged for the GitHub tooling ... allowing to customize GitHub Discussion emails Hi all, I just also added the documentation on my latest addition to the GitHub tooling. Now we can customize the email titles sent to the mailinglists … I bet you folks will be relieved by that, right? https://cwiki.apache.org/confluence/display/INFRA/Git+-+.asf.yaml+features I would suggest something like: custom_subjects: new_pr: "[PR] {title}" close_pr: "Re: [PR] {title}" comment_pr: "Re: [PR] {title}" diffcomment: "Re: [PR] {title}" merge_pr: "Re: [PR] {title}" new_issue: "[I] {title}" comment_issue: "Re: [I] {title}" close_issue: "Re: [I] {title}" catchall: "[GH] {title}" new_discussion: "[D] {title}" edit_discussion: "Re: [D] {title}" close_discussion: "Re: [D] {title}" close_discussion_with_comment: "Re: [D] {title}" reopen_discussion: "Re: [D] {title}" new_comment_discussion: "Re: [D] {title}" edit_comment_discussion: " Re: [D] {title}" delete_comment_discussion: " Re: [D] {title}" Tell me what you think? Chris
